Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamza/90782/useless tooltip deal cancellation #7958

Conversation

hamza-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • Bug - Useless checkbox item in tooltip

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Mar 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 6:18am

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/7958](https://github.com/binary-com/deriv-app/pull/7958)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-90782uselesstooltip-fcd143.binary.sx?qa_server=red.binaryws.com&app_id=24092
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-90782uselesstooltip-fcd143.binary.sx
- **App ID**: `24092`

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-90782uselesstooltip-fcd143.binary.sx/

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Merging #7958 (771be88) into master (62bd456) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #7958   +/-   ##
=======================================
  Coverage   20.57%   20.57%           
=======================================
  Files        1635     1635           
  Lines       36993    36991    -2     
  Branches     7367     7367           
=======================================
  Hits         7610     7610           
+ Misses      28632    28630    -2     
  Partials      751      751           
Impacted Files Coverage Δ
...ct-card/contract-card-items/toggle-card-dialog.tsx 0.00% <0.00%> (ø)

aizad-deriv
aizad-deriv previously approved these changes Mar 20, 2023
henry-deriv
henry-deriv previously approved these changes Mar 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
14.2% 14.2% Duplication

@jim-deriv jim-deriv merged commit 2cb2fe0 into binary-com:master May 12, 2023
nijil-deriv pushed a commit to nijil-deriv/deriv-app that referenced this pull request May 24, 2023
* fix: deal cancellation tooltip removed the checkbox

* fix: Merge conflicts resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants