test: evgeniy/ 91704/ language settings radio button test coverage #8014

yauheni-deriv · 2023-03-24T04:48:36Z

Changes:

Please include a summary of the change and which issue is fixed below:

...

When you need to add unit test

If this change disrupt current flow
If this change is adding new flow

When you need to add integration test

If components from external libraries are being used to define the flow, e.g. @deriv/components
If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

Ensure utility / function has a test case
Ensure all the tests are passing

Type of change

vercel · 2023-03-24T04:48:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 30, 2023 9:11am

sonarcloud · 2023-03-24T04:52:12Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.3% Duplication

github-actions · 2023-03-24T05:00:10Z

A production App ID was automatically generated for this PR. (log)

PR: test: evgeniy/ 91704/ language settings radio button test coverage #8014
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-yauheni-deriv-evgeniy-91704languagese-08316b.binary.sx?qa_server=red.binaryws.com&app_id=24067
- Original: https://deriv-app-git-fork-yauheni-deriv-evgeniy-91704languagese-08316b.binary.sx
App ID: 24067

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8014](https://github.com/binary-com/deriv-app/pull/8014)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-yauheni-deriv-evgeniy-91704languagese-08316b.binary.sx?qa_server=red.binaryws.com&app_id=24067
    - **Original**: https://deriv-app-git-fork-yauheni-deriv-evgeniy-91704languagese-08316b.binary.sx
- **App ID**: `24067`

github-actions · 2023-03-24T05:00:26Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	20
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-yauheni-deriv-evgeniy-91704languagese-08316b.binary.sx/

codecov-commenter · 2023-03-24T05:08:48Z

Codecov Report

Merging #8014 (6702dbd) into master (5a419a5) will increase coverage by 0.00%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #8014   +/-   ##
=======================================
  Coverage   20.89%   20.90%           
=======================================
  Files        1555     1555           
  Lines       36067    36067           
  Branches     7059     7059           
=======================================
+ Hits         7536     7539    +3     
+ Misses      27790    27787    -3     
  Partials      741      741

Impacted Files	Coverage Δ
...onents/language-settings/language-radio-button.tsx	`100.00% <ø> (+100.00%)`	⬆️

niloofar-deriv · 2023-04-04T05:45:38Z

packages/account/src/Components/language-settings/__tests__/language-radio-button.spec.tsx

+            'settings-language__language-link--active'
+        );
+
+        const btn = screen.getByRole('radio');


Suggested change

const btn = screen.getByRole('radio');

const button = screen.getByRole('radio');

Isn't this more clear? 🤔

…test_coverage

niloofar-deriv

LGTM 👍

…test_coverage

sonarcloud · 2023-04-30T09:03:43Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
4.4% Duplication

github-actions · 2023-04-30T09:22:48Z

⏳ Generating Lighthouse report...

…inary-com#8014) * test: language settings radio button test coverage * refactor: variable name change --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>

test: language settings radio button test coverage

71277a4

yauheni-deriv requested a review from yashim-deriv as a code owner March 24, 2023 04:48

boring-cyborg bot added the Account label Mar 24, 2023

vercel bot deployed to Preview March 24, 2023 05:10 View deployment

vercel bot deployed to Preview March 28, 2023 08:29 View deployment

niloofar-deriv reviewed Apr 4, 2023

View reviewed changes

jim-deriv previously approved these changes Apr 4, 2023

View reviewed changes

hubert-deriv previously approved these changes Apr 4, 2023

View reviewed changes

suisin-deriv previously approved these changes Apr 4, 2023

View reviewed changes

refactor: variable name change

b6f5d96

yauheni-deriv dismissed stale reviews from suisin-deriv, jim-deriv, and hubert-deriv via b6f5d96 April 4, 2023 07:43

yauheni-deriv force-pushed the evgeniy/91704/language_settings_radio_btn_test_coverage branch from eb15f2a to b6f5d96 Compare April 4, 2023 07:43

Merge branch 'master' into evgeniy/91704/language_settings_radio_btn_…

6876eba

…test_coverage

yauheni-deriv requested review from hubert-deriv, suisin-deriv, jim-deriv and niloofar-deriv April 4, 2023 07:44

amina-deriv approved these changes Apr 4, 2023

View reviewed changes

jim-deriv approved these changes Apr 4, 2023

View reviewed changes

niloofar-deriv approved these changes Apr 4, 2023

View reviewed changes

vercel bot deployed to Preview April 4, 2023 07:58 View deployment

henry-deriv approved these changes Apr 5, 2023

View reviewed changes

Merge branch 'master' into evgeniy/91704/language_settings_radio_btn_…

bfb2c46

…test_coverage

vercel bot deployed to Preview April 6, 2023 12:45 View deployment

Merge branch 'master' into evgeniy/91704/language_settings_radio_btn_…

51f72d3

…test_coverage

vercel bot deployed to Preview April 17, 2023 05:35 View deployment

Merge branch 'master' into evgeniy/91704/language_settings_radio_btn_…

6702dbd

…test_coverage

vercel bot deployed to Preview April 30, 2023 09:11 View deployment

jim-deriv merged commit 5893b81 into binary-com:master May 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: evgeniy/ 91704/ language settings radio button test coverage #8014

test: evgeniy/ 91704/ language settings radio button test coverage #8014

yauheni-deriv commented Mar 24, 2023

vercel bot commented Mar 24, 2023 •

edited

Loading

sonarcloud bot commented Mar 24, 2023

github-actions bot commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 24, 2023 •

edited

Loading

codecov-commenter commented Mar 24, 2023 •

edited

Loading

niloofar-deriv Apr 4, 2023

niloofar-deriv left a comment

sonarcloud bot commented Apr 30, 2023

github-actions bot commented Apr 30, 2023

	const btn = screen.getByRole('radio');
	const button = screen.getByRole('radio');

test: evgeniy/ 91704/ language settings radio button test coverage #8014

test: evgeniy/ 91704/ language settings radio button test coverage #8014

Conversation

yauheni-deriv commented Mar 24, 2023

Changes:

When you need to add unit test

When you need to add integration test

Test coverage checklist (for reviewer)

Type of change

vercel bot commented Mar 24, 2023 • edited Loading

sonarcloud bot commented Mar 24, 2023

github-actions bot commented Mar 24, 2023 • edited Loading

github-actions bot commented Mar 24, 2023 • edited Loading

codecov-commenter commented Mar 24, 2023 • edited Loading

Codecov Report

niloofar-deriv Apr 4, 2023

Choose a reason for hiding this comment

niloofar-deriv left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Apr 30, 2023

github-actions bot commented Apr 30, 2023

vercel bot commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 24, 2023 •

edited

Loading

codecov-commenter commented Mar 24, 2023 •

edited

Loading