Have the matching ads feature enabled by default under the filter section in Deriv P2P #8086

farhan-nurzi-deriv · 2023-03-31T02:22:12Z

Changes:

Please include a summary of the change and which issue is fixed below:

...

When you need to add unit test

If this change disrupt current flow
If this change is adding new flow

When you need to add integration test

If components from external libraries are being used to define the flow, e.g. @deriv/components
If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

Ensure utility / function has a test case
Ensure all the tests are passing

Type of change

vercel · 2023-03-31T02:22:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 11, 2023 8:27am

sonarcloud · 2023-03-31T02:24:14Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.1% Duplication

github-actions · 2023-03-31T02:34:33Z

A production App ID was automatically generated for this PR. (log)

PR: Have the matching ads feature enabled by default under the filter section in Deriv P2P #8086
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-farhan-nurzi-deriv-p2ps-233-enable-ma-f57a36.binary.sx?qa_server=red.binaryws.com&app_id=23938
- Original: https://deriv-app-git-fork-farhan-nurzi-deriv-p2ps-233-enable-ma-f57a36.binary.sx
App ID: 23938

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8086](https://github.com/binary-com/deriv-app/pull/8086)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-p2ps-233-enable-ma-f57a36.binary.sx?qa_server=red.binaryws.com&app_id=23938
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-p2ps-233-enable-ma-f57a36.binary.sx
- **App ID**: `23938`

github-actions · 2023-03-31T02:34:51Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-p2ps-233-enable-ma-f57a36.binary.sx/

ameerul-deriv

LGTM

codecov-commenter · 2023-03-31T06:13:10Z

Codecov Report

Merging #8086 (5feeddf) into master (d5c38a0) will increase coverage by 39.93%.
Report is 314 commits behind head on master.
The diff coverage is n/a.

❗ Current head 5feeddf differs from pull request most recent head f109f41. Consider uploading reports for the commit f109f41 to get more accurate results

@@             Coverage Diff             @@
##           master    #8086       +/-   ##
===========================================
+ Coverage    0.05%   39.99%   +39.93%     
===========================================
  Files         117      212       +95     
  Lines        3425     4501     +1076     
  Branches      893     1240      +347     
===========================================
+ Hits            2     1800     +1798     
+ Misses       3423     2469      -954     
- Partials        0      232      +232

see 329 files with indirect coverage changes

github-actions · 2023-05-31T00:22:34Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

… P2PS-233/enable-matching-ads-feature-by-default

sonarcloud · 2023-05-31T02:24:34Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.1% Duplication

farhan-nurzi-deriv · 2023-05-31T02:32:23Z

commenting to remove the stale label

github-actions · 2023-08-01T00:24:25Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

… P2PS-233/enable-matching-ads-feature-by-default

github-actions · 2023-09-05T10:03:21Z

⏳ Generating Lighthouse report...

gitguardian · 2023-09-05T10:03:23Z

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	`2563d60`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	`2563d60`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

… P2PS-233/enable-matching-ads-feature-by-default

sonarcloud · 2023-09-11T08:10:48Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
9 Code Smells

No Coverage information
1.2% Duplication

chore: enable matching ads filter by default

9227680

boring-cyborg bot added the P2P label Mar 31, 2023

vercel bot deployed to Preview March 31, 2023 02:34 View deployment

ameerul-deriv approved these changes Mar 31, 2023

View reviewed changes

nada-deriv approved these changes Mar 31, 2023

View reviewed changes

farrah-deriv previously approved these changes Mar 31, 2023

View reviewed changes

github-actions bot added the Stale label May 31, 2023

Merge branch 'master' of https://github.com/binary-com/deriv-app into…

5feeddf

… P2PS-233/enable-matching-ads-feature-by-default

vercel bot deployed to Preview May 31, 2023 02:37 View deployment

github-actions bot removed the Stale label Jun 1, 2023

github-actions bot added the Stale label Aug 1, 2023

farrah-deriv removed the Stale label Aug 1, 2023

Merge branch 'master' of https://github.com/binary-com/deriv-app into…

2563d60

… P2PS-233/enable-matching-ads-feature-by-default

farhan-nurzi-deriv requested a review from nijil-deriv as a code owner September 5, 2023 10:02

vercel bot deployed to Preview September 5, 2023 10:33 View deployment

Merge branch 'master' of https://github.com/binary-com/deriv-app into…

36ad7c5

… P2PS-233/enable-matching-ads-feature-by-default

vercel bot deployed to Preview September 6, 2023 08:26 View deployment

fix: reset function should turn matching ads on

f109f41

farhan-nurzi-deriv dismissed farrah-deriv’s stale review via f109f41 September 11, 2023 08:04

ameerul-deriv approved these changes Sep 11, 2023

View reviewed changes

niloofar-deriv approved these changes Sep 11, 2023

View reviewed changes

nada-deriv approved these changes Sep 11, 2023

View reviewed changes

vercel bot deployed to Preview September 11, 2023 08:27 View deployment

farrah-deriv approved these changes Sep 11, 2023

View reviewed changes

ali-hosseini-deriv merged commit 125fc0f into binary-com:master Sep 18, 2023
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Have the matching ads feature enabled by default under the filter section in Deriv P2P #8086

Have the matching ads feature enabled by default under the filter section in Deriv P2P #8086

farhan-nurzi-deriv commented Mar 31, 2023 •

edited

Loading

vercel bot commented Mar 31, 2023 •

edited

Loading

sonarcloud bot commented Mar 31, 2023

github-actions bot commented Mar 31, 2023 •

edited

Loading

github-actions bot commented Mar 31, 2023 •

edited

Loading

ameerul-deriv left a comment

codecov-commenter commented Mar 31, 2023 •

edited by codecov bot

Loading

github-actions bot commented May 31, 2023

sonarcloud bot commented May 31, 2023

farhan-nurzi-deriv commented May 31, 2023

github-actions bot commented Aug 1, 2023

github-actions bot commented Sep 5, 2023 •

edited

Loading

gitguardian bot commented Sep 5, 2023 •

edited

Loading

sonarcloud bot commented Sep 11, 2023

Have the matching ads feature enabled by default under the filter section in Deriv P2P #8086

Have the matching ads feature enabled by default under the filter section in Deriv P2P #8086

Conversation

farhan-nurzi-deriv commented Mar 31, 2023 • edited Loading

Changes:

When you need to add unit test

When you need to add integration test

Test coverage checklist (for reviewer)

Type of change

vercel bot commented Mar 31, 2023 • edited Loading

sonarcloud bot commented Mar 31, 2023

github-actions bot commented Mar 31, 2023 • edited Loading

github-actions bot commented Mar 31, 2023 • edited Loading

ameerul-deriv left a comment

Choose a reason for hiding this comment

codecov-commenter commented Mar 31, 2023 • edited by codecov bot Loading

Codecov Report

github-actions bot commented May 31, 2023

sonarcloud bot commented May 31, 2023

farhan-nurzi-deriv commented May 31, 2023

github-actions bot commented Aug 1, 2023

github-actions bot commented Sep 5, 2023 • edited Loading

gitguardian bot commented Sep 5, 2023 • edited Loading

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

sonarcloud bot commented Sep 11, 2023

farhan-nurzi-deriv commented Mar 31, 2023 •

edited

Loading

vercel bot commented Mar 31, 2023 •

edited

Loading

github-actions bot commented Mar 31, 2023 •

edited

Loading

github-actions bot commented Mar 31, 2023 •

edited

Loading

codecov-commenter commented Mar 31, 2023 •

edited by codecov bot

Loading

github-actions bot commented Sep 5, 2023 •

edited

Loading

gitguardian bot commented Sep 5, 2023 •

edited

Loading