Ameerul /Bug 93397 Notification_counter_not_updated_correctly

[ameerul-deriv]

Changes:

Please include a summary of the change and which issue is fixed below:

• Used new p2p notifications hook and deleted old code for getting unseen notifications

When you need to add unit test

• If this change disrupt current flow
• If this change is adding new flow

When you need to add integration test

• If components from external libraries are being used to define the flow, e.g. @deriv/components
• If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

• Ensure utility / function has a test case
• Ensure all the tests are passing

Type of change

• Bug fix
• New feature
• Update feature
• Refactor code
• Translation to code
• Translation to crowdin
• Script configuration
• Improve performance
• Style only
• Dependency update
• Documentation update
• Release

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 14, 2023 8:16am

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
1.8% Duplication

[github-actions]

A production App ID was automatically generated for this PR. (log)

• PR: Ameerul /Bug 93397 Notification_counter_not_updated_correctly #8262
• URLs:
  • w/ App ID + Server: https://deriv-app-git-fork-ameerul-deriv-bug-93397-notification-ecd70c.binary.sx?qa_server=red.binaryws.com&app_id=32208
  • Original: https://deriv-app-git-fork-ameerul-deriv-bug-93397-notification-ecd70c.binary.sx
• App ID: 32208

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8262](https://github.com/binary-com/deriv-app/pull/8262)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-bug-93397-notification-ecd70c.binary.sx?qa_server=red.binaryws.com&app_id=32208
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-bug-93397-notification-ecd70c.binary.sx
- **App ID**: `32208`

[github-actions]

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-bug-93397-notification-ecd70c.binary.sx/

[adrienne-deriv]

LGTM

[codecov-commenter]

Codecov Report

Merging #8262 (8037914) into master (d7aaba9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #8262      +/-   ##
==========================================
- Coverage   20.74%   20.73%   -0.01%     
==========================================
  Files        1538     1538              
  Lines       35933    35924       -9     
  Branches     7030     7027       -3     
==========================================
- Hits         7453     7448       -5     
+ Misses      27733    27730       -3     
+ Partials      747      746       -1     

Impacted Files	Coverage Δ
packages/cashier/src/stores/general-store.ts	80.00% <ø> (+1.29%)	⬆️
...ackages/cashier/src/containers/cashier/cashier.tsx	96.00% <100.00%> (+0.08%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[farzin-deriv]

Just a heads-up, The logic inside the useP2PNotificationCount hook is temporary, It's listening to local storage changes and the actual logic exists somewhere else and it updates the local storage.
Later someone from the P2P team should help to move the actual logic itself to the hook and remove all the local storage things 🙇🏻

cc: @ameerul-deriv @farrah-deriv

[niloofar-deriv]

LGTM 👍