Jim | Hamza/88557/replace-connect-with-use-store-trader-parent

[jim-deriv]

Changes:

Please include a summary of the change and which issue is fixed below:

• ...

When you need to add unit test

• If this change disrupt current flow
• If this change is adding new flow

When you need to add integration test

• If components from external libraries are being used to define the flow, e.g. @deriv/components
• If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

• Ensure utility / function has a test case
• Ensure all the tests are passing

Type of change

• Bug fix
• New feature
• Update feature
• Refactor code
• Translation to code
• Translation to crowdin
• Script configuration
• Improve performance
• Style only
• Dependency update
• Documentation update
• Release

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 12, 2023 3:48am

[github-actions]

A production App ID was automatically generated for this PR. (log)

• PR: Jim | Hamza/88557/replace-connect-with-use-store-trader-parent #8270
• URLs:
  • w/ App ID + Server: https://deriv-app-git-fork-jim-deriv-jim-88557replace-connect-wi-cf8fea.binary.sx?qa_server=red.binaryws.com&app_id=24070
  • Original: https://deriv-app-git-fork-jim-deriv-jim-88557replace-connect-wi-cf8fea.binary.sx
• App ID: 24070

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8270](https://github.com/binary-com/deriv-app/pull/8270)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-jim-deriv-jim-88557replace-connect-wi-cf8fea.binary.sx?qa_server=red.binaryws.com&app_id=24070
    - **Original**: https://deriv-app-git-fork-jim-deriv-jim-88557replace-connect-wi-cf8fea.binary.sx
- **App ID**: `24070`

[github-actions]

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-jim-deriv-jim-88557replace-connect-wi-cf8fea.binary.sx/

[codecov-commenter]

Codecov Report

Merging #8270 (804d223) into master (54f6d7b) will decrease coverage by 0.07%.
The diff coverage is 3.67%.

@@            Coverage Diff             @@
##           master    #8270      +/-   ##
==========================================
- Coverage   19.98%   19.91%   -0.07%     
==========================================
  Files        1816     1817       +1     
  Lines       41173    41304     +131     
  Branches     8191     8189       -2     
==========================================
- Hits         8227     8225       -2     
- Misses      32094    32227     +133     
  Partials      852      852              

Impacted Files	Coverage Δ
...components/src/components/u-i-loader/ui-loader.tsx	0.00% <ø> (ø)
packages/stores/src/mockStore.ts	0.00% <ø> (ø)
...s/Elements/ContractDrawer/contract-drawer-card.jsx	0.00% <0.00%> (ø)
...onents/Elements/ContractDrawer/contract-drawer.jsx	0.00% <0.00%> (ø)
...dals/MarketUnavailableModal/market-unavailable.jsx	0.00% <0.00%> (ø)
...portedContractModal/unsupported-contract-modal.jsx	0.00% <0.00%> (ø)
.../Elements/PositionsDrawer/positions-modal-card.jsx	0.00% <0.00%> (ø)
...ements/TogglePositions/toggle-positions-mobile.jsx	0.00% <0.00%> (ø)
...src/App/Components/Form/TimePicker/time-picker.jsx	0.00% <0.00%> (ø)
.../trader/src/App/Containers/Modals/trade-modals.jsx	0.00% <0.00%> (ø)
... and 61 more

[gitguardian]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	9956f27	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	9956f27	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.2% Duplication

[github-actions]

⏳ Generating Lighthouse report...