feat: 3rd party payment dispute reason added #8464

nada-deriv · 2023-05-04T09:42:45Z

Changes:

Please include a summary of the change and which issue is fixed below:

... Added 3rd party payment dispute reason for sellers.

When you need to add unit test

If this change disrupt current flow
If this change is adding new flow

When you need to add integration test

If components from external libraries are being used to define the flow, e.g. @deriv/components
If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

Ensure utility / function has a test case
Ensure all the tests are passing

Type of change

vercel · 2023-05-04T09:42:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 16, 2023 7:06am

github-actions · 2023-05-04T09:58:38Z

A production App ID was automatically generated for this PR. (log)

PR: feat: 3rd party payment dispute reason added #8464
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-nada-deriv-nada-p2ps-216dispute-reason.binary.sx?qa_server=red.binaryws.com&app_id=32108
- Original: https://deriv-app-git-fork-nada-deriv-nada-p2ps-216dispute-reason.binary.sx
App ID: 32108

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8464](https://github.com/binary-com/deriv-app/pull/8464)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-216dispute-reason.binary.sx?qa_server=red.binaryws.com&app_id=32108
    - **Original**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-216dispute-reason.binary.sx
- **App ID**: `32108`

github-actions · 2023-05-04T09:59:09Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	20
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-216dispute-reason.binary.sx/

niloofar-deriv · 2023-05-05T06:48:10Z

packages/components/src/components/radio-group/radio-group.tsx

-                        </label>
-                    </ItemWrapper>
-                ))}
+                children.map(


what about using a filter children instead of adding this condition here?

niloofar-deriv

LGTM 👍

ameerul-deriv

LGTM

farhan-nurzi-deriv · 2023-05-08T09:40:16Z

packages/components/src/components/radio-group/radio-group.tsx

+                    .filter(item => !item.props.is_hidden)
+                    .map(
+                        item =>
+                            !item.props.is_hidden && (


We dont need this condition here anymore right?

sonarcloud · 2023-05-08T10:41:42Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

codecov-commenter · 2023-05-08T11:02:41Z

Codecov Report

Merging #8464 (15c265e) into master (d5c38a0) will increase coverage by 20.75%.
Report is 214 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 15c265e differs from pull request most recent head dffc60b. Consider uploading reports for the commit dffc60b to get more accurate results

@@             Coverage Diff             @@
##           master    #8464       +/-   ##
===========================================
+ Coverage    0.05%   20.81%   +20.75%     
===========================================
  Files         117     1561     +1444     
  Lines        3425    36119    +32694     
  Branches      893     7091     +6198     
===========================================
+ Hits            2     7518     +7516     
- Misses       3423    27859    +24436     
- Partials        0      742      +742

Files Changed	Coverage Δ
...ponents/src/components/radio-group/radio-group.tsx	`0.00% <0.00%> (ø)`
...tails/order-details-complain-modal-radio-group.jsx	`0.00% <ø> (ø)`

... and 1598 files with indirect coverage changes

github-actions · 2023-07-09T00:29:33Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

gitguardian · 2023-07-10T06:02:27Z

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	`faa2883`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	`faa2883`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

coveralls · 2023-07-10T06:32:09Z

coverage: 10.145% (+0.3%) from 9.826% when pulling dffc60b on nada-deriv:nada/P2PS-216/dispute-reason into 440be0a on binary-com:master.

matin-deriv · 2023-08-16T05:45:30Z

packages/components/src/components/radio-group/radio-group.tsx

+    value: string;
+    label: string;
+    disabled: boolean;
+    is_hidden?: boolean;


Don't you need to give this a falsy default value so that the rest of the usage won't fail? (better to false than undefined in line no.55)

As you work on updating the shared component, please remember to incorporate the QA checklist for all the areas where this component has been utilised.

.../p2p/src/components/order-details/__tests__/order-details-complain-modal-radio-group.spec.js

packages/components/src/components/radio-group/radio-group.tsx

sonarcloud · 2023-08-16T06:57:48Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

niloofar-deriv

LGTM 👍

feat: 3rd party payment dispute reason added

34a4c3b

boring-cyborg bot added Components P2P labels May 4, 2023

vercel bot deployed to Preview May 4, 2023 09:58 View deployment

farhan-nurzi-deriv previously approved these changes May 5, 2023

View reviewed changes

niloofar-deriv reviewed May 5, 2023

View reviewed changes

fix: replace map with condition to use filter

a0b75cf

nada-deriv dismissed farhan-nurzi-deriv’s stale review via a0b75cf May 5, 2023 11:39

vercel bot deployed to Preview May 5, 2023 11:55 View deployment

niloofar-deriv previously approved these changes May 5, 2023

View reviewed changes

ameerul-deriv previously approved these changes May 8, 2023

View reviewed changes

farhan-nurzi-deriv reviewed May 8, 2023

View reviewed changes

fix: removed condition duplication

15c265e

nada-deriv dismissed stale reviews from ameerul-deriv and niloofar-deriv via 15c265e May 8, 2023 10:38

vercel bot deployed to Preview May 8, 2023 10:51 View deployment

farhan-nurzi-deriv approved these changes May 9, 2023

View reviewed changes

github-actions bot added the Stale label Jul 9, 2023

Merge branch 'master' into nada/P2PS-216/dispute-reason

faa2883

farrah-deriv removed the Stale label Jul 10, 2023

vercel bot deployed to Preview July 10, 2023 06:21 View deployment

Merge branch 'master' into nada/P2PS-216/dispute-reason

44294c3

vercel bot deployed to Preview July 25, 2023 05:13 View deployment

feat: updated with latest master

9865503

vercel bot deployed to Preview July 31, 2023 06:51 View deployment

nada-deriv requested review from matin-deriv, maryia-deriv, farrah-deriv, nijil-deriv, ali-hosseini-deriv, prince-deriv and sandeep-deriv as code owners August 4, 2023 10:13

boring-cyborg bot added Bot Trader labels Aug 4, 2023

vercel bot deployed to Preview August 4, 2023 10:29 View deployment

nada-deriv force-pushed the nada/P2PS-216/dispute-reason branch from 9703c77 to 9865503 Compare August 4, 2023 12:01

feat: merged with latest master

708b35a

farrah-deriv previously approved these changes Aug 15, 2023

View reviewed changes

vercel bot deployed to Preview August 15, 2023 05:45 View deployment

matin-deriv reviewed Aug 16, 2023

View reviewed changes

fix: pr review comment

3968601

nada-deriv dismissed farrah-deriv’s stale review via 3968601 August 16, 2023 06:34

niloofar-deriv reviewed Aug 16, 2023

View reviewed changes

vercel bot deployed to Preview August 16, 2023 06:50 View deployment

fix: updated test

dffc60b

niloofar-deriv approved these changes Aug 16, 2023

View reviewed changes

matin-deriv approved these changes Aug 16, 2023

View reviewed changes

vercel bot deployed to Preview August 16, 2023 07:06 View deployment

farrah-deriv approved these changes Aug 16, 2023

View reviewed changes

bahar-sadeghzadeh merged commit e6fc72e into binary-com:master Sep 14, 2023
3 of 4 checks passed

nada-deriv mentioned this pull request Mar 8, 2024

[FEQ] - P2P-V2 active orders #14040

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 3rd party payment dispute reason added #8464

feat: 3rd party payment dispute reason added #8464

nada-deriv commented May 4, 2023

vercel bot commented May 4, 2023 •

edited

Loading

github-actions bot commented May 4, 2023 •

edited

Loading

github-actions bot commented May 4, 2023 •

edited

Loading

niloofar-deriv May 5, 2023

nada-deriv May 5, 2023

niloofar-deriv left a comment

ameerul-deriv left a comment

farhan-nurzi-deriv May 8, 2023

nada-deriv May 8, 2023

sonarcloud bot commented May 8, 2023

codecov-commenter commented May 8, 2023 •

edited by codecov bot

Loading

github-actions bot commented Jul 9, 2023

gitguardian bot commented Jul 10, 2023 •

edited

Loading

coveralls commented Jul 10, 2023 •

edited

Loading

matin-deriv Aug 16, 2023

sonarcloud bot commented Aug 16, 2023

niloofar-deriv left a comment

feat: 3rd party payment dispute reason added #8464

feat: 3rd party payment dispute reason added #8464

Conversation

nada-deriv commented May 4, 2023

Changes:

When you need to add unit test

When you need to add integration test

Test coverage checklist (for reviewer)

Type of change

vercel bot commented May 4, 2023 • edited Loading

github-actions bot commented May 4, 2023 • edited Loading

github-actions bot commented May 4, 2023 • edited Loading

niloofar-deriv May 5, 2023

Choose a reason for hiding this comment

nada-deriv May 5, 2023

Choose a reason for hiding this comment

niloofar-deriv left a comment

Choose a reason for hiding this comment

ameerul-deriv left a comment

Choose a reason for hiding this comment

farhan-nurzi-deriv May 8, 2023

Choose a reason for hiding this comment

nada-deriv May 8, 2023

Choose a reason for hiding this comment

sonarcloud bot commented May 8, 2023

codecov-commenter commented May 8, 2023 • edited by codecov bot Loading

Codecov Report

github-actions bot commented Jul 9, 2023

gitguardian bot commented Jul 10, 2023 • edited Loading

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

coveralls commented Jul 10, 2023 • edited Loading

matin-deriv Aug 16, 2023

Choose a reason for hiding this comment

sonarcloud bot commented Aug 16, 2023

niloofar-deriv left a comment

Choose a reason for hiding this comment

vercel bot commented May 4, 2023 •

edited

Loading

github-actions bot commented May 4, 2023 •

edited

Loading

github-actions bot commented May 4, 2023 •

edited

Loading

codecov-commenter commented May 8, 2023 •

edited by codecov bot

Loading

gitguardian bot commented Jul 10, 2023 •

edited

Loading

coveralls commented Jul 10, 2023 •

edited

Loading