Farzin/PRODQA-921/Cashier dark mode issue

[farzin-deriv]

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

Screen.Recording.2023-05-23.at.12.23.59.PM.mov

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 30, 2023 1:26pm

[github-actions]

A production App ID was automatically generated for this PR. (log)

• PR: Farzin/PRODQA-921/Cashier dark mode issue #8700
• URLs:
  • w/ App ID + Server: https://deriv-app-git-fork-farzin-deriv-farzin-prodqa-921cashier-a95702.binary.sx?qa_server=red.binaryws.com&app_id=32820
  • Original: https://deriv-app-git-fork-farzin-deriv-farzin-prodqa-921cashier-a95702.binary.sx
• App ID: 32820

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8700](https://github.com/binary-com/deriv-app/pull/8700)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farzin-deriv-farzin-prodqa-921cashier-a95702.binary.sx?qa_server=red.binaryws.com&app_id=32820
    - **Original**: https://deriv-app-git-fork-farzin-deriv-farzin-prodqa-921cashier-a95702.binary.sx
- **App ID**: `32820`

[github-actions]

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	20
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-farzin-deriv-farzin-prodqa-921cashier-a95702.binary.sx/

[shayan-deriv]

it's not that important but just for having more consistency for our code style I'm asking this. I saw in this PR we are getting our data from store like this:

const {
        common: { current_language },
    } = useStore();

but here you actually changed the syntax. IMO the way you wrote it is more clear to understand , So I think we can discuss and agree on one of the formats for the future

[farzin-deriv]

@shayan-deriv Yeah agree with you, I personally try to avoid nested object destructuring cause it will be hard to follow by eye. It similar to nested ternary operator situation 👀

[shayan-deriv]

LGTM

[codecov-commenter]

Codecov Report

Merging #8700 (7ad9763) into master (f443097) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #8700   +/-   ##
=======================================
  Coverage   40.02%   40.02%           
=======================================
  Files         212      212           
  Lines        4497     4497           
  Branches     1239     1239           
=======================================
  Hits         1800     1800           
  Misses       2465     2465           
  Partials      232      232           

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication