Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vinu/ fix: close the dashboard dialog when xml is uploaded #8792

Conversation

vinu-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@boring-cyborg boring-cyborg bot added the Bot label May 29, 2023
@vercel
Copy link

vercel bot commented May 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 0:32am

@vinu-deriv vinu-deriv changed the title Vinu/ fix: close the dashboard dailog when xml is uploaded Vinu/ fix: close the dashboard dialog when xml is uploaded May 29, 2023
@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8792](https://github.com/binary-com/deriv-app/pull/8792)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-vinu-deriv-vinu-95307fix-google-drive-76f496.binary.sx?qa_server=red.binaryws.com&app_id=24093
    - **Original**: https://deriv-app-git-fork-vinu-deriv-vinu-95307fix-google-drive-76f496.binary.sx
- **App ID**: `24093`

@codecov-commenter
Copy link

Codecov Report

Merging #8792 (c0c57d2) into master (c1159af) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #8792   +/-   ##
=======================================
  Coverage   39.63%   39.63%           
=======================================
  Files         212      212           
  Lines        4494     4494           
  Branches     1237     1237           
=======================================
  Hits         1781     1781           
  Misses       2482     2482           
  Partials      231      231           

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-vinu-deriv-vinu-95307fix-google-drive-76f496.binary.sx/

@sandeep-deriv sandeep-deriv merged commit 2dc5301 into binary-com:master May 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants