shontzu/WALL-823/inaccurate-jurisdictions-displayed-when-language-is-non-English

[shontzu-deriv]

Changes:

the account_type_card arg has been localized before passing into the switch case, causing it to return default because there are no matching english cases

Screenshots:

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 21, 2023 4:57am

[github-actions]

A production App ID was automatically generated for this PR. (log)

• PR: shontzu/WALL-823/inaccurate-jurisdictions-displayed-when-language-is-non-English #8919
• URLs:
  • w/ App ID + Server: https://deriv-app-git-fork-shontzu-deriv-shontzu-wall-823inaccur-08ee0d.binary.sx?qa_server=red.binaryws.com&app_id=24190
  • Original: https://deriv-app-git-fork-shontzu-deriv-shontzu-wall-823inaccur-08ee0d.binary.sx
• App ID: 24190

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8919](https://github.com/binary-com/deriv-app/pull/8919)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shontzu-deriv-shontzu-wall-823inaccur-08ee0d.binary.sx?qa_server=red.binaryws.com&app_id=24190
    - **Original**: https://deriv-app-git-fork-shontzu-deriv-shontzu-wall-823inaccur-08ee0d.binary.sx
- **App ID**: `24190`

[github-actions]

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	20
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-shontzu-wall-823inaccur-08ee0d.binary.sx/

[codecov]

Codecov Report

Merging #8919 (9617d93) into master (243b35d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8919   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files         117     117           
  Lines        3422    3422           
  Branches      891     891           
======================================
  Hits            2       2           
  Misses       3420    3420           

[hamza-deriv]

Why same condition is used twice?

[shontzu-deriv]

because it other languages (i.e. spanish, Indonesian) there is no dash (-) and it end up at default again

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.2% Duplication

[ali-hosseini-deriv]

✨ PR has been merged by Paimon the Release Bot