Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shontzu/96457/Unable_to_reset_investor_password_for_swap_free_account #9391

Conversation

shontzu-deriv
Copy link
Contributor

@shontzu-deriv shontzu-deriv commented Jul 20, 2023

Changes:

Please provide a summary of the change.
Redmine: https://redmine.deriv.cloud/issues/96457#Unable_to_reset_investor_password_for_swap_free_account.
CU: https://app.clickup.com/t/20696747/CFDS-742
Slack Discussion: https://deriv-group.slack.com/archives/C0333CCQ4FM/p1689667020931369

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 18, 2023 8:33am

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9391](https://github.com/binary-com/deriv-app/pull/9391)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shontzu-deriv-shontzu-96457unabletore-e3b6da.binary.sx?qa_server=red.binaryws.com&app_id=24166
    - **Original**: https://deriv-app-git-fork-shontzu-deriv-shontzu-96457unabletore-e3b6da.binary.sx
- **App ID**: `24166`

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-shontzu-96457unabletore-e3b6da.binary.sx/

@coveralls
Copy link

coveralls commented Jul 20, 2023

Coverage Status

coverage: 8.884%. remained the same when pulling 68e249b on shontzu-deriv:shontzu/96457/Unable_to_reset_investor_password_for_swap_free_account into 1082e43 on binary-com:master.

@shontzu-deriv shontzu-deriv changed the title fix: fixed shontzu-deriv:shontzu/96457/Unable_to_reset_investor_password_for_swap_free_account Jul 20, 2023
@shontzu-deriv shontzu-deriv changed the title shontzu-deriv:shontzu/96457/Unable_to_reset_investor_password_for_swap_free_account shontzu/96457/Unable_to_reset_investor_password_for_swap_free_account Jul 20, 2023
@@ -13,7 +13,7 @@ const ResetPasswordIntent = ({ current_list, children, is_eu, ...props }: TReset
const reset_password_type = localStorage.getItem('cfd_reset_password_type') || 'main'; // Default to main
const has_intent =
reset_password_intent &&
/(real|demo)\.(financial_stp|financial|synthetic|synthetic_svg|synthetic_bvi|financial_svg|financial_bvi|financial_fx|financial_v)/.test(
/(real|demo)\.(financial_stp|financial|synthetic|synthetic_svg|synthetic_bvi|financial_svg|financial_bvi|financial_fx|financial_v|all_svg|dxtrade)/.test(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shontzu-deriv how about all-demo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for Demo Account i think it is just demo instead of all-demo

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

matin-deriv
matin-deriv previously approved these changes Jul 25, 2023
mahdiyeh-deriv
mahdiyeh-deriv previously approved these changes Jul 25, 2023
hirad-deriv and others added 5 commits July 26, 2023 14:32
…/96457/Unable_to_reset_investor_password_for_swap_free_account
…p_free_account' of github.com:shontzu-deriv/deriv-app into shontzu/96457/Unable_to_reset_investor_password_for_swap_free_account
…/96457/Unable_to_reset_investor_password_for_swap_free_account
shontzu-deriv and others added 2 commits September 4, 2023 11:57
…create-Investor-Password-for-Derived-Vanuatu-account

shontzu/CFDS-898/Unable-to-create-Investor-Password-for-Derived-Vanuatu-account
mahdiyeh-deriv
mahdiyeh-deriv previously approved these changes Sep 5, 2023
hirad-deriv
hirad-deriv previously approved these changes Sep 5, 2023
… into shontzu/96457/Unable_to_reset_investor_password_for_swap_free_account
…p_free_account' of github.com:shontzu-deriv/deriv-app into shontzu/96457/Unable_to_reset_investor_password_for_swap_free_account
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ali-hosseini-deriv ali-hosseini-deriv merged commit bca027c into binary-com:master Sep 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants