Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adrienne / Fix issues with environment variable not in webpack config for core #9397

Merged

Conversation

adrienne-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@boring-cyborg boring-cyborg bot added the Core label Jul 20, 2023
@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 20, 2023 8:13am

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9397](https://github.com/binary-com/deriv-app/pull/9397)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-fix-rudderstack-env.binary.sx?qa_server=red.binaryws.com&app_id=24035
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-fix-rudderstack-env.binary.sx
- **App ID**: `24035`

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-fix-rudderstack-env.binary.sx/

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@coveralls
Copy link

Coverage Status

coverage: 8.874%. remained the same when pulling 38871da on adrienne-deriv:fix-rudderstack-env into d87b4d3 on binary-com:master.

@ali-hosseini-deriv ali-hosseini-deriv merged commit 711d3e0 into binary-com:master Jul 20, 2023
3 checks passed
mahdiyeh-deriv pushed a commit to mahdiyeh-deriv/deriv-app that referenced this pull request Jul 25, 2023
… for core (binary-com#9397)

* fix: issues with environment variable not in webpack config for core

* chore: updated test cases
mahdiyeh-deriv pushed a commit to mahdiyeh-deriv/deriv-app that referenced this pull request Jul 25, 2023
… for core (binary-com#9397)

* fix: issues with environment variable not in webpack config for core

* chore: updated test cases
mahdiyeh-deriv pushed a commit to mahdiyeh-deriv/deriv-app that referenced this pull request Jul 25, 2023
… for core (binary-com#9397)

* fix: issues with environment variable not in webpack config for core

* chore: updated test cases
mahdiyeh-deriv pushed a commit to mahdiyeh-deriv/deriv-app that referenced this pull request Jul 25, 2023
… for core (binary-com#9397)

* fix: issues with environment variable not in webpack config for core

* chore: updated test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants