Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamza/chore: remove the broker code mt5 notification from traders hub #9734

Conversation

hamza-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.
User Story: As a [type of user], I want [an action] so that [a benefit/a value].
As a user I do not want to see the MT5 broker name change pop-up notification on Trader's Hub since this issue no longer happens.

CU Card: https://app.clickup.com/t/20696747/CFDS-925

Screenshots:

Screenshot 2023-08-17 at 9 21 26 AM

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 17, 2023 3:33am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9734](https://github.com/binary-com/deriv-app/pull/9734)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-925remove-brok-27c219.binary.sx?qa_server=red.binaryws.com&app_id=32877
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-925remove-brok-27c219.binary.sx
- **App ID**: `32877`

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-cfds-925remove-brok-27c219.binary.sx/

@hamza-deriv hamza-deriv changed the title chore: remove the broker code mt5 notification from traders hub Hamza/chore: remove the broker code mt5 notification from traders hub Aug 17, 2023
Copy link
Contributor

@shontzu-deriv shontzu-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Coverage Status

coverage: 10.136% (+0.001%) from 10.135% when pulling e4ecd0f on hamza-deriv:hamza/CFDS-925/remove-broker-code-mt5-notification into 7885480 on binary-com:master.

@DerivFE DerivFE merged commit 06983ee into binary-com:master Sep 18, 2023
6 checks passed
@DerivFE
Copy link
Collaborator

DerivFE commented Sep 18, 2023

✨ PR has been merged by Paimon the Release Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants