-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Niloofar | Mark | @deriv/integration and playwright implementations [POC] #9761
Niloofar | Mark | @deriv/integration and playwright implementations [POC] #9761
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-niloofar-deriv-niloofar-862k6k9q2deri-7949e3.binary.sx/ |
3120051
to
a449d46
Compare
306a527
to
b4613ed
Compare
b4613ed
to
a7dc2d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I'd have a think about renaming all those e2e-test
folders to something else, as they aren't really for e2e anymore.
playwright.config.ts
Outdated
], | ||
|
||
/* Run your local dev server before starting the tests */ | ||
// webServer: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the auto start stuff actually work? Can it ever work with our setup? If not, can we just delete these lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't setup this because we need to serve different packages for running the tests!
For example for your example test I need to serve core and appstore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove the extra commented configs
…r/862k6k9q2/deriv-test-tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Since I worked on this POC let's get at least one other approver though :)
…r/862k6k9q2/deriv-test-tool
…r/862k6k9q2/deriv-test-tool
…r/862k6k9q2/deriv-test-tool
…r/862k6k9q2/deriv-test-tool
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
⏳ Generating Lighthouse report... |
This PR includes the following changes:
@deriv/integration
package to the project for adding ourmocked_data
and general integration files! later we can move this package outside the deriv-app and use it where ever we want!Playwright
configuration in the root of the project! also for making sure that everything will working properly in the future I added this in theaccount
andintegration
packages as well!end-to-end
folder I removed that and added Mocked files fromend-to-end
folder to the@deriv/integration
package from @markwylde-deriv 's PR