Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FarhanNurzi/PRODQA-1253/Cashier deposit page not fully visible in iphone #9779

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .stylelintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ module.exports = {
'shorthand-property-no-redundant-values': true,
'string-no-newline': true,
'time-min-milliseconds': 100,
'unit-allowed-list': ['fr', 'px', 'em', 'rem', '%', 'vw', 'vh', 'deg', 'ms', 's', 'dpcm'],
'unit-allowed-list': ['fr', 'px', 'em', 'rem', '%', 'svh', 'vw', 'vh', 'deg', 'ms', 's', 'dpcm'],
'value-keyword-case': 'lower',
},
extends: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const PageContainer: React.FC<React.PropsWithChildren<TProps>> = observer(
{!is_loading && (
<div className='page-container__content'>
{!is_mobile && left && <div className='page-container__sidebar--left'>{left}</div>}
<ThemedScrollbars className='page-container__main'>
<ThemedScrollbars className='page-container__main' height='calc(100svh - 8rem)'>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the reference 👇 , i substract it with 8rem because page header and navbar use 8rem of the view height.

image

{!hide_breadcrumb && <CashierBreadcrumb />}
{is_mobile && left && <div className='page-container__sidebar--left'>{left}</div>}
{children}
Expand Down