fix: cannot read properties of null issue fixed #9823
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-1469trackjs-error.binary.sx/ |
| if (response) { | ||
| if (!response.error) { | ||
| const { get_account_status } = response; | ||
| const { status } = get_account_status?.authentication?.identity ?? {}; | ||
| this.root_store.general_store.setPoiStatus(status); | ||
| } else { | ||
| this.setErrorMessage(response?.error); |
There was a problem hiding this comment.
no need to check for response here since we are already doing it on line 142
|
Kudos, SonarCloud Quality Gate passed!
|
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | 116a6ef | nx.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
Kudos, SonarCloud Quality Gate passed!
|
* fix: cannot read properties of null issue fixed * fix: review fix * fix: circle ci fail issue fixed * fix: circle ci fail issue fixed * fix: remove unwanted file change
* fix: cannot read properties of null issue fixed * fix: review fix * fix: circle ci fail issue fixed * fix: circle ci fail issue fixed * fix: remove unwanted file change
Changes:
fixed issue with cannot read properties of null
Screenshots:
Please provide some screenshots of the change.