Kate / DTRA-384 /Video improvement

[kate-deriv]

Changes:

• CSS changes
• Refactor component: remove width and hight attributes from ContractTypeDescriptionVideo + remove isMobile() (will be deprecated soon)
• Refactor test cases

Screenshots:

Please provide some screenshots of the change.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Aug 29, 2023 2:45pm

[github-actions]

A production App ID was automatically generated for this PR. (log)

• PR: Kate / DTRA-384 /Video improvement #9868
• URLs:
  • w/ App ID + Server: https://deriv-app-git-fork-kate-deriv-kate-videoimprovement.binary.sx?qa_server=red.binaryws.com&app_id=32210
  • Original: https://deriv-app-git-fork-kate-deriv-kate-videoimprovement.binary.sx
• App ID: 32210

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/9868](https://github.com/binary-com/deriv-app/pull/9868)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-videoimprovement.binary.sx?qa_server=red.binaryws.com&app_id=32210
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-videoimprovement.binary.sx
- **App ID**: `32210`

[github-actions]

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-videoimprovement.binary.sx/

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[henry-deriv]

does it work with width being 480px instead of 100%?

[kate-deriv]

Yes, you can try test link

[henry-deriv]

ok lets change it to 480px or 48rem. That width is per design i believe

[kate-deriv]

Sorry, my bad, it'll work with 100%, but not with rem/px.

[DerivFE]

✨ PR has been merged by Paimon the Release Bot