Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FarhanNurzi/WALL-1669/Add accordion to Wallet header #9938

Merged
merged 13 commits into from
Sep 13, 2023
Merged

FarhanNurzi/WALL-1669/Add accordion to Wallet header #9938

merged 13 commits into from
Sep 13, 2023

Conversation

farhan-nurzi-deriv
Copy link
Contributor

@farhan-nurzi-deriv farhan-nurzi-deriv commented Sep 4, 2023 •
edited
Loading

Changes:

Please provide a summary of the change.

Screenshots:

Screen.Recording.2023-09-07.at.10.59.39.AM.mov

@vercel
Copy link

vercel bot commented Sep 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 13, 2023 4:16am

@farhan-nurzi-deriv
Copy link
Contributor Author

Waiting for #9870

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/9938](https://github.com/binary-com/deriv-app/pull/9938)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wallet-accordion.binary.sx?qa_server=red.binaryws.com&app_id=32883
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wallet-accordion.binary.sx
- **App ID**: `32883`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wallet-accordion.binary.sx/

@farhan-nurzi-deriv farhan-nurzi-deriv marked this pull request as ready for review September 5, 2023 05:12
mahdiyeh-deriv
mahdiyeh-deriv previously approved these changes Sep 11, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@yashim-deriv yashim-deriv merged commit 8968499 into binary-com:master Sep 13, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisyahlen-deriv thisyahlen-deriv thisyahlen-deriv left review comments

@yashim-deriv yashim-deriv yashim-deriv approved these changes

@mahdiyeh-deriv mahdiyeh-deriv mahdiyeh-deriv left review comments

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

@amina-deriv amina-deriv Awaiting requested review from amina-deriv amina-deriv is a code owner

Assignees
No one assigned
Labels
Account Components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@farhan-nurzi-deriv @yashim-deriv @mahdiyeh-deriv @thisyahlen-deriv @Farhan-slurrp