-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thisyahlen/chore: add styles to wallet card carousel #9957
thisyahlen/chore: add styles to wallet card carousel #9957
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-1658-a7194e.binary.sx/ |
packages/wallets/src/components/WalletsCarousel/WalletsCarousel.tsx
Outdated
Show resolved
Hide resolved
packages/wallets/src/components/WalletsCarouselContent/WalletsCarouselContent.tsx
Outdated
Show resolved
Hide resolved
packages/wallets/src/components/WalletsCarouselContent/WalletsCarouselContent.tsx
Outdated
Show resolved
Hide resolved
/> | ||
</div> | ||
<div className='wallets-carousel-content__actions'> | ||
<WalletListCardIActions is_desktop_wallet={false} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<WalletListCardIActions is_desktop_wallet={false} /> | |
<WalletListCardIActions /> |
can the component itself know and handle if it is desktop_wallet or not internally instead of a prop like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but waiting for @farhan-nurzi-deriv breakpoints PR. So temporary 😸
packages/wallets/src/components/WalletsCarouselContent/WalletsCarouselContent.tsx
Show resolved
Hide resolved
packages/wallets/src/components/WalletsCarouselContent/WalletsCarouselContent.tsx
Outdated
Show resolved
Hide resolved
packages/wallets/src/components/WalletListCardIActions/WalletListCardIActions.tsx
Outdated
Show resolved
Hide resolved
packages/wallets/src/components/WalletListCardIActions/WalletListCardIActions.tsx
Outdated
Show resolved
Hide resolved
packages/wallets/src/components/WalletListCardIActions/WalletListCardIActions.tsx
Outdated
Show resolved
Hide resolved
…hisyahlen/WALL-1658/Wallet_Carousel_UI
SonarCloud Quality Gate failed. 1 Bug No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Changes:
Please provide a summary of the change.
Screenshots: