Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thisyahlen/chore: add styles to wallet card carousel #9957

Conversation

thisyahlen-deriv
Copy link
Contributor

@thisyahlen-deriv thisyahlen-deriv commented Sep 5, 2023

Changes:

Please provide a summary of the change.

Screenshots:

Screenshot 2023-09-06 at 10 53 15 AM

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 13, 2023 4:25am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9957](https://github.com/binary-com/deriv-app/pull/9957)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-1658-a7194e.binary.sx?qa_server=red.binaryws.com&app_id=38763
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-1658-a7194e.binary.sx
- **App ID**: `38763`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-1658-a7194e.binary.sx/

packages/wallets/src/components/WalletCard/WalletCard.scss Outdated Show resolved Hide resolved
packages/wallets/src/components/WalletCard/WalletCard.tsx Outdated Show resolved Hide resolved
/>
</div>
<div className='wallets-carousel-content__actions'>
<WalletListCardIActions is_desktop_wallet={false} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<WalletListCardIActions is_desktop_wallet={false} />
<WalletListCardIActions />

can the component itself know and handle if it is desktop_wallet or not internally instead of a prop like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but waiting for @farhan-nurzi-deriv breakpoints PR. So temporary 😸

packages/wallets/src/components/WalletCard/WalletCard.tsx Outdated Show resolved Hide resolved
packages/wallets/src/AppContent.tsx Outdated Show resolved Hide resolved
yashim-deriv
yashim-deriv previously approved these changes Sep 13, 2023
@yashim-deriv yashim-deriv merged commit 85cb075 into binary-com:master Sep 13, 2023
2 of 4 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants