Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor--dbot-tours #9990

Merged
merged 49 commits into from
Sep 14, 2023

Conversation

rupato-deriv
Copy link
Contributor

@rupato-deriv rupato-deriv commented Sep 7, 2023

Deriv-Bot tour changes

  • This will be a feature branch for refactor of dbot tours on mobile and desktop.
  • Refactoring for the mobile tours and desktop tours to reduce code complexity.
  • Added test cases for the components that were splitted from refactoring.
  • Removed tour-slider.tsx and splitted this file into bot-builder.tsx, on-boarding.tsx and mobile-tours.tsx.
  • Also seperated the utils and the config file into their own Folders.
  • Refactored tour trigger dialog, by removing tour-trigger-dialog.tsx and added tour-start.tsx and tour-end.tsx.

@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 13, 2023 8:47am

…e-code-complexity

Rupato/bot 566/fix  cognitive code complexity
@boring-cyborg boring-cyborg bot added the Bot label Sep 7, 2023
@rupato-deriv rupato-deriv changed the title chore: create refactor branch refactor--dbot-tours Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9990](https://github.com/binary-com/deriv-app/pull/9990)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rupato-deriv-refactor-dbot-tours.binary.sx?qa_server=red.binaryws.com&app_id=23801
    - **Original**: https://deriv-app-git-fork-rupato-deriv-refactor-dbot-tours.binary.sx
- **App ID**: `23801`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-rupato-deriv-refactor-dbot-tours.binary.sx/

…i/bot-565/critical-code-smell-refactor-function
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.7% 2.7% Duplication

@bahar-sadeghzadeh bahar-sadeghzadeh merged commit 852b702 into binary-com:master Sep 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants