-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI external signer support (e.g. hardware wallet) #4
Changes from 2 commits
6cdbc83
eef8d64
450cb40
62ac119
3f845ea
24815c6
1c4b456
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -199,6 +199,7 @@ void OptionsDialog::setModel(OptionsModel *_model) | |
connect(ui->prune, &QCheckBox::clicked, this, &OptionsDialog::togglePruneWarning); | ||
connect(ui->pruneSize, qOverload<int>(&QSpinBox::valueChanged), this, &OptionsDialog::showRestartWarning); | ||
connect(ui->databaseCache, qOverload<int>(&QSpinBox::valueChanged), this, &OptionsDialog::showRestartWarning); | ||
connect(ui->externalSignerPath, &QLineEdit::textChanged, [this]{ showRestartWarning(); }); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note to other reviewers. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should disable |
||
connect(ui->threadsScriptVerif, qOverload<int>(&QSpinBox::valueChanged), this, &OptionsDialog::showRestartWarning); | ||
/* Wallet */ | ||
connect(ui->spendZeroConfChange, &QCheckBox::clicked, this, &OptionsDialog::showRestartWarning); | ||
|
@@ -233,6 +234,7 @@ void OptionsDialog::setMapper() | |
/* Wallet */ | ||
mapper->addMapping(ui->spendZeroConfChange, OptionsModel::SpendZeroConfChange); | ||
mapper->addMapping(ui->coinControlFeatures, OptionsModel::CoinControlFeatures); | ||
mapper->addMapping(ui->externalSignerPath, OptionsModel::ExternalSignerPath); | ||
|
||
/* Network */ | ||
mapper->addMapping(ui->mapPortUpnp, OptionsModel::MapPortUPnP); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eef8d64
This should take into account
ENABLE_EXTERNAL_SIGNER
.May I suggest adding a private slot
update
orupdateState
and move all logic there?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a fix in bitcoin/bitcoin#21935. I agree this whole toggling code needs a refactor.