Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify block height label #40

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Clarify block height label #40

merged 1 commit into from
Aug 27, 2020

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Jul 25, 2020

Prefer "block height" instead of "number of blocks".

This was done while testing bitcoin/bitcoin#16981.

@hebasto hebasto changed the title gui: Clarify block height label Clarify block height label Jul 25, 2020
promag
promag reviewed Jul 26, 2020
View reviewed changes
src/qt/forms/debugwindow.ui
@@ -290,7 +290,7 @@
<item row="11" column="0">
<widget class="QLabel" name="label_3">
<property name="text">
<string>Current number of blocks</string>
<string>Current block height</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny that "height" is not in the translations.

@michaelfolkson
Copy link
Contributor

ACK b6dcc6d. I don't think there are any other obvious examples in the GUI where "block height" should replace "number of blocks" except for translations.

@maflcko
Copy link
Contributor

maflcko commented Aug 27, 2020 

$ git grep --ignore-case 'block height' | wc
     65     793    7793
$ git grep --ignore-case 'number of blocks' | wc
    141    1125   12941

@hebasto
Copy link
Member Author

hebasto commented Aug 27, 2020 •
edited
Loading 

$ git grep --ignore-case 'block height' -- :^doc/release-notes :^src/qt/locale | wc -l
60
$ git grep --ignore-case 'number of blocks' -- :^doc/release-notes :^src/qt/locale | wc -l
37

@maflcko
Copy link
Contributor

maflcko commented Aug 27, 2020

Fair enough. I wanted to show that both wordings are used, so it seems arbitrary to change only one?

@maflcko
Copy link
Contributor

maflcko commented Aug 27, 2020

cr ACK b6dcc6d

probably doesn't matter much, but shouldn't hurt either

@hebasto
Copy link
Member Author

hebasto commented Aug 27, 2020

Fair enough. I wanted to show that both wordings are used, so it seems arbitrary to change only one?

In the GUI this is one, I guess.

@maflcko
Copy link
Contributor

maflcko commented Aug 27, 2020

block height is probably better because it implies linearity (chain) instead of number of blocks, which could also mean the number of blocks in the block tree.

@maflcko maflcko merged commit 15886b0 into bitcoin-core:master Aug 27, 2020
@hebasto
Copy link
Member Author

hebasto commented Aug 27, 2020

@MarcoFalke

block height is probably better because it implies linearity (chain) instead of number of blocks, which could also mean the number of blocks in the block tree.

Exactly.

@hebasto hebasto deleted the 200725-height branch August 27, 2020 18:43
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 28, 2020
Merge bitcoin-core/gui#40: Clarify block height label
9c0a0b1 
b6dcc6d gui: Clarify block height label (Hennadii Stepanov)

Pull request description:

  Prefer "block height" instead of "number of blocks".

  This was done while testing bitcoin#16981.

ACKs for top commit:
  michaelfolkson:
    ACK b6dcc6d. I don't think there are any other obvious examples in the GUI where "block height" should replace "number of blocks" except for translations.
  MarcoFalke:
    cr ACK b6dcc6d

Tree-SHA512: ec3b48c1af5d613ed657ad51f2caddea774376736ecc02343d54518986e35ec37f1745b059814b5be92b5e5c2bb2970d17159b24c6e88b9316803d4de5327c31
apoelstra added a commit to apoelstra/elements that referenced this pull request Dec 3, 2020
@apoelstra
Merge 15886b0 into merged_master (Bitcoin PR bitcoin-core/gui#40)
7b52bef
laanwj pushed a commit that referenced this pull request Dec 9, 2020
Squashed 'src/crc32c/' changes from 224988680f..b5ef9be675
90c0f26 
b5ef9be675 Merge #1: Merge changes from upstream
9e7f512430 Merge remote-tracking branch 'origin/master' into bitcoin-fork
1f85030246 Add support for ARM64 darwin (#43)
3bb959c982 Remove unnecessary reinterpret_cast (#42)
2e97ab26b1 Fix (unused) ReadUint64LE for BE machines (#41)
47b40d2209 Bump dependencies. (#40)
ba74185625 Move CI to Visual Studio 2019.
efa301a7e5 Allow different C/C++ standards when this is used as a subproject.
cc6d71465e CMake: Use configure_package_config_file()

git-subtree-dir: src/crc32c
git-subtree-split: b5ef9be6755a2e61e2988bb238f13d1c0ee1fa0a
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Mar 22, 2021
@apoelstra
Merge 15886b0 into merged_master (Bitcoin PR bitcoin-core/gui#40)
264dff3
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#40: Clarify block height label
843c166 
b6dcc6d gui: Clarify block height label (Hennadii Stepanov)

Pull request description:

  Prefer "block height" instead of "number of blocks".

  This was done while testing bitcoin#16981.

ACKs for top commit:
  michaelfolkson:
    ACK b6dcc6d. I don't think there are any other obvious examples in the GUI where "block height" should replace "number of blocks" except for translations.
  MarcoFalke:
    cr ACK b6dcc6d

Tree-SHA512: ec3b48c1af5d613ed657ad51f2caddea774376736ecc02343d54518986e35ec37f1745b059814b5be92b5e5c2bb2970d17159b24c6e88b9316803d4de5327c31
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#40: Clarify block height label
53dd955 
b6dcc6d gui: Clarify block height label (Hennadii Stepanov)

Pull request description:

  Prefer "block height" instead of "number of blocks".

  This was done while testing bitcoin#16981.

ACKs for top commit:
  michaelfolkson:
    ACK b6dcc6d. I don't think there are any other obvious examples in the GUI where "block height" should replace "number of blocks" except for translations.
  MarcoFalke:
    cr ACK b6dcc6d

Tree-SHA512: ec3b48c1af5d613ed657ad51f2caddea774376736ecc02343d54518986e35ec37f1745b059814b5be92b5e5c2bb2970d17159b24c6e88b9316803d4de5327c31
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#40: Clarify block height label
81b6e72 
b6dcc6d gui: Clarify block height label (Hennadii Stepanov)

Pull request description:

  Prefer "block height" instead of "number of blocks".

  This was done while testing bitcoin#16981.

ACKs for top commit:
  michaelfolkson:
    ACK b6dcc6d. I don't think there are any other obvious examples in the GUI where "block height" should replace "number of blocks" except for translations.
  MarcoFalke:
    cr ACK b6dcc6d

Tree-SHA512: ec3b48c1af5d613ed657ad51f2caddea774376736ecc02343d54518986e35ec37f1745b059814b5be92b5e5c2bb2970d17159b24c6e88b9316803d4de5327c31
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#40: Clarify block height label
8d04b42 
b6dcc6d gui: Clarify block height label (Hennadii Stepanov)

Pull request description:

  Prefer "block height" instead of "number of blocks".

  This was done while testing bitcoin#16981.

ACKs for top commit:
  michaelfolkson:
    ACK b6dcc6d. I don't think there are any other obvious examples in the GUI where "block height" should replace "number of blocks" except for translations.
  MarcoFalke:
    cr ACK b6dcc6d

Tree-SHA512: ec3b48c1af5d613ed657ad51f2caddea774376736ecc02343d54518986e35ec37f1745b059814b5be92b5e5c2bb2970d17159b24c6e88b9316803d4de5327c31
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#40: Clarify block height label
901b101 
b6dcc6d gui: Clarify block height label (Hennadii Stepanov)

Pull request description:

  Prefer "block height" instead of "number of blocks".

  This was done while testing bitcoin#16981.

ACKs for top commit:
  michaelfolkson:
    ACK b6dcc6d. I don't think there are any other obvious examples in the GUI where "block height" should replace "number of blocks" except for translations.
  MarcoFalke:
    cr ACK b6dcc6d

Tree-SHA512: ec3b48c1af5d613ed657ad51f2caddea774376736ecc02343d54518986e35ec37f1745b059814b5be92b5e5c2bb2970d17159b24c6e88b9316803d4de5327c31
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 15, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#40: Clarify block height label
3122a6b 
b6dcc6d gui: Clarify block height label (Hennadii Stepanov)

Pull request description:

  Prefer "block height" instead of "number of blocks".

  This was done while testing bitcoin#16981.

ACKs for top commit:
  michaelfolkson:
    ACK b6dcc6d. I don't think there are any other obvious examples in the GUI where "block height" should replace "number of blocks" except for translations.
  MarcoFalke:
    cr ACK b6dcc6d

Tree-SHA512: ec3b48c1af5d613ed657ad51f2caddea774376736ecc02343d54518986e35ec37f1745b059814b5be92b5e5c2bb2970d17159b24c6e88b9316803d4de5327c31
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 16, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#40: Clarify block height label
cd741d0 
b6dcc6d gui: Clarify block height label (Hennadii Stepanov)

Pull request description:

  Prefer "block height" instead of "number of blocks".

  This was done while testing bitcoin#16981.

ACKs for top commit:
  michaelfolkson:
    ACK b6dcc6d. I don't think there are any other obvious examples in the GUI where "block height" should replace "number of blocks" except for translations.
  MarcoFalke:
    cr ACK b6dcc6d

Tree-SHA512: ec3b48c1af5d613ed657ad51f2caddea774376736ecc02343d54518986e35ec37f1745b059814b5be92b5e5c2bb2970d17159b24c6e88b9316803d4de5327c31
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Sep 16, 2021
@hebasto @PiRK
gui: Clarify block height label
6e51b72 
Summary:
> Prefer "block height" instead of "number of blocks".

This is a backport of [[bitcoin-core/gui#40 | core-gui#40]]

Test Plan:
`ninja && src/qt/bitcoin-qt`
Menu Window > Information

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10130
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@promag promag promag left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hebasto @michaelfolkson @maflcko @promag