Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schnorr (Incremental) Half Aggregation #1566

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fjahr
Copy link

@fjahr fjahr commented Jul 2, 2024

This ports over the work from b-wagn in BlockstreamResearch/secp256k1-zkp#261

In the second commit I have addressed the follow-ups though I was not always sure if I understood them correctly since they weren't inline. Please let me know if they are correct then I can squash the commit here and open it as a PR on zkp.

fjahr and others added 2 commits July 2, 2024 18:28
Co-authored-by: Benedikt <crypto@benedikt-wagner.dev>
- we may want to add a header to the include file that links to the BIP
- there's still a mention of aggsig_size
- we may want to move aggregate before inc_aggregate
- we should mention expected size of input aggsig array in_aggregate
- 'Should be aggsig_len = 32*(n+1)' -> 'Must be'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants