-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Set -Werror for all CI builds #938
ci: Set -Werror for all CI builds #938
Conversation
Uff ok, this is failing for multiple reasons:
Fixing the first item is a little bit annoying. We could simply patch the generated It would be nice to call I believe a better way would be to have some maintainer variable with additional flags that can be set from the outside like |
An The only concern I have with EXTRACFLAGS is just that it gets into my environment and then messes up my tests but is weird enough that I don't think to look for it. :P Is there any particular reason it needs to rerun both ways such that rerunning configure is a concern? However its setup it should be done in a way that makes it relatively easy to drop on some CI builds. Because if some build starts throwing false positives it may be best to ignore it (e.g. if it's S390 or some other weird config and silencing it requires hurting performance or crapping up the codebase), or maybe not, but the decision shouldn't be driven by having to all-or-nothing the Werror or dropping the build. |
e5cc5d9
to
2026df0
Compare
I ended up doing this (naming it Let's see what Cirrus says. |
Fixes one of the items in bitcoin-core#923, namely the warnings of the form '_putenv' redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] This also cleans up the way we add CFLAGS, in particular flags enabling warnings. Now we perform some more fine-grained checking for flag support, which is not strictly necessary but the changes also help to document autoconf.ac.
This also tidies the list of environment variables in .cirrus.yml.
2026df0
to
8d8cd48
Compare
Closed in favor of #944 |
Let's see if that passes...