Skip to content

Commit

Permalink
Linkers: add version to allow deprecation of old references
Browse files Browse the repository at this point in the history
Fixes an issue reported by Steve Lee (thanks!)
  • Loading branch information
harding committed Feb 9, 2022
1 parent 1861b80 commit f517230
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
9 changes: 7 additions & 2 deletions _includes/linkers/issues.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ issues.md: creates Markdown reference-style links to issues, pull
requests, and other templated URLs.
Input:
- v: (integer) version number for backwards-incompatible changes
- issues: (CSV) the issue numbers to create links for separated by
commas with no spaces. For a given number, a separate link will
be created for *all* supported repositories
Expand Down Expand Up @@ -31,10 +32,14 @@ requests, and other templated URLs.
[bips #{{_issue}}]: https://github.com/bitcoin/bips/issues/{{_issue}}
[bolts #{{_issue}}]: https://github.com/lightning/bolts/issues/{{_issue}}
[rust bitcoin #{{_issue}}]: https://github.com/rust-bitcoin/rust-bitcoin/issues/{{_issue}}
[rust-lightning #{{_issue}}]: https://github.com/rust-bitcoin/rust-lightning/issues/{{_issue}}
[ldk #{{_issue}}]: https://github.com/lightningdevkit/rust-lightning/issues/{{_issue}}
[review club #{{_issue}}]: https://bitcoincore.reviews/{{_issue}}
[hwi #{{_issue}}]: https://github.com/bitcoin-core/HWI/issues/{{_issue}}
[btcpay server #{{_issue}}]: https://github.com/btcpayserver/btcpayserver/issues/{{_issue}}
[bdk #{{_issue}}]: https://github.com/bitcoindevkit/bdk/issues/{{_issue}}

{% if include.v > 0 %}
[ldk #{{_issue}}]: https://github.com/lightningdevkit/rust-lightning/issues/{{_issue}}
{% else %}
[rust-lightning #{{_issue}}]: https://github.com/rust-bitcoin/rust-lightning/issues/{{_issue}}
{% endif %}
{% endfor %}
2 changes: 1 addition & 1 deletion _posts/en/newsletters/2022-01-19-newsletter.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ Proposals (BIPs)][bips repo], and [Lightning BOLTs][bolts repo].*
(["nulldummy"][bip147]) in the PSBT.

{% include references.md %}
{% include linkers/issues.md issues="2063,912,1013,6006,590,591,669,950" %}
{% include linkers/issues.md v=1 issues="2063,912,1013,6006,590,591,669,950" %}
[poelstra nulldummy]: https://github.com/rust-bitcoin/rust-bitcoin/pull/669#issuecomment-1008021007
[dmw legal]: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-January/019741.html
[todd ctv]: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-January/019738.html
Expand Down
2 changes: 1 addition & 1 deletion _posts/ja/newsletters/2022-01-19-newsletter.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ lang: ja
署名をしたくない署名者が空のバイト列(["nulldummy"][bip147])をPSBTに入れるべきかどうかという[興味深いコメント][poelstra nulldummy]もありました。

{% include references.md %}
{% include linkers/issues.md issues="2063,912,1013,6006,590,591,669,950" %}
{% include linkers/issues.md v=1 issues="2063,912,1013,6006,590,591,669,950" %}
[poelstra nulldummy]: https://github.com/rust-bitcoin/rust-bitcoin/pull/669#issuecomment-1008021007
[dmw legal]: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-January/019741.html
[todd ctv]: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-January/019738.html
Expand Down

0 comments on commit f517230

Please sign in to comment.