Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All AWS resources should have "tags.Name" #42

Closed
arm4b opened this issue Jan 31, 2023 · 2 comments · Fixed by #51
Closed

All AWS resources should have "tags.Name" #42

arm4b opened this issue Jan 31, 2023 · 2 comments · Fixed by #51
Labels
bug Something isn't working complexity:easy enhancement New feature or request
Milestone

Comments

@arm4b
Copy link
Member

arm4b commented Jan 31, 2023

Many of the created AWS resources managed by Terraform in this repo have tags.Name, but some are missing due to oversight:

image
image

resource "aws_security_group" "allow_http" {
name = "${var.aws_resource_identifier_supershort}-http"
description = "Allow HTTP traffic"
vpc_id = var.create_vpc == "true" ? aws_vpc.main[0].id : null
ingress {
description = "HTTP"
from_port = 80
to_port = 80
protocol = "tcp"
cidr_blocks = ["0.0.0.0/0"]
}
egress {
from_port = 0
to_port = 0
protocol = "-1"
cidr_blocks = ["0.0.0.0/0"]
}
}

Identify all the resources without Name tag and make sure that's in place as tags.Name is the first identifier users see in the AWS UI.

@arm4b arm4b added bug Something isn't working enhancement New feature or request complexity:easy labels Jan 31, 2023
@PhillypHenning
Copy link
Contributor

Agreed that this is very much needed

@mickmcgrath13
Copy link
Contributor

@LeoDiazL LeoDiazL linked a pull request Feb 24, 2023 that will close this issue
@arm4b arm4b added this to the v0.2.0 milestone Feb 27, 2023
@arm4b arm4b closed this as completed in #51 Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working complexity:easy enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants