Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging.ini does not symlinked inside docker CT #1723

Closed
bitphage opened this issue Apr 16, 2019 · 2 comments
Closed

logging.ini does not symlinked inside docker CT #1723

bitphage opened this issue Apr 16, 2019 · 2 comments
Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design 6 Build Impact flag identifying the build process 6 Deployment Impact flag identifying the deployment process (e.g. Docker, Travis, etc.) 9a Tiny Effort estimation indicating TBD
Milestone
4.0.0 - Protocol ...

Comments

@bitphage
Copy link

Docker entrypoint bitsharesentry.sh creates symlink for config.ini, but not for logging.ini. Because of this, logging may appear as non-working.
@bitphage bitphage mentioned this issue Apr 16, 2019
Closed
8 tasks
@pmconrad pmconrad added 3d Bug Classification indicating the existing implementation does not match the intention of the design 6 Build Impact flag identifying the build process 6 Deployment Impact flag identifying the deployment process (e.g. Docker, Travis, etc.) 9a Tiny Effort estimation indicating TBD labels Apr 17, 2019
@pmconrad
Copy link
Contributor

IMO the docker build needs a rework anyway. The resulting image is HUGE. Better use a two-stage build where the seconds stage copies build artifacts into a new base image, like e. g. https://github.com/soundac/SounDAC-Source/blob/master/Dockerfile

@abitmore abitmore added this to the Future Feature Release milestone Apr 19, 2019
This was referenced Sep 24, 2019
Merged
Open
@pmconrad
Copy link
Contributor

Resolved by #2010

@ryanRfox ryanRfox removed this from the 4.1.0 - Feature Release milestone Oct 15, 2019
@MichelSantos MichelSantos mentioned this issue Oct 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design 6 Build Impact flag identifying the build process 6 Deployment Impact flag identifying the deployment process (e.g. Docker, Travis, etc.) 9a Tiny Effort estimation indicating TBD
Projects
None yet
Milestone
4.0.0 - Protocol Upgrade Release
Development

No branches or pull requests
4 participants
@bitphage @pmconrad @abitmore @ryanRfox