Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTLC Operations memo (optional) item #1967

Closed
ioBanker opened this issue Sep 1, 2019 · 6 comments
Closed

HTLC Operations memo (optional) item #1967

ioBanker opened this issue Sep 1, 2019 · 6 comments
Assignees
Labels

Comments

@ioBanker
Copy link
Member

ioBanker commented Sep 1, 2019

HTLC Operations memo (optional) item

Introducing this feature is very helpful step to satisfy the future of Cross Chain Swaps, parties involved within the Cross Chain Swaps will have to communicate their external addresses or references and info within the HTLC transaction upon creation.

In case we implement Cross Chain Swap feature within our UI in future, the memo (optional) item field will be used to communicate and to confirm external addresses and will be used as reference for transaction.

@pmconrad
Copy link
Contributor

pmconrad commented Sep 2, 2019

Perhaps include this in bitshares/bsips#195 .

@jmjatlanta
Copy link
Contributor

I like the idea. Should it work like transactions, where there is a separate memo signing key? I think not, as the information should probably be public.

@pmconrad
Copy link
Contributor

pmconrad commented Sep 2, 2019

I think memos should be encrypted using sender's and recipient's memo keys, as in transactions.

@ioBanker
Copy link
Member Author

ioBanker commented Sep 3, 2019

On some chains they are encrypting it, on some they don't.

I believe for the sake of protecting memo it should be encrypted because the usage itself of the memo will be only in case of HTLC contract already created and sent to particular BTS account, there is no need for someone else to read it.

@jmjatlanta
Copy link
Contributor

Added to BSIP 64.

@abitmore
Copy link
Member

Fixed via #1998.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants