Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default for amount of open orders returned #2165

Closed
1 of 17 tasks
sschiessl-bcp opened this issue May 2, 2020 · 3 comments
Closed
1 of 17 tasks

Default for amount of open orders returned #2165

sschiessl-bcp opened this issue May 2, 2020 · 3 comments

Comments

@sschiessl-bcp
Copy link

sschiessl-bcp commented May 2, 2020

User Story
As a power trader I want to be able to use any public API without being castrated in my trading.

The new pagination in full account API is too strict. We went from unlimited to returning a 100. I suggest to set the default to 500. This will only affect a handfull of users, but those users are especially important. This default can be re-evaluated once proper lazy loading is availble for all UIs.

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Additional Context (optional)
Add any other context about your request here.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@bangzi1001
Copy link
Contributor

UI doesn't show more than 100 open orders for users
bitshares/bitshares-ui#3248

@abitmore
Copy link
Member

abitmore commented May 2, 2020

It was expected that UI would adapt to core changes in a few months. But it has been 10 months since the release of the get_full_accounts API change. Another API get_account_limit_orders which is more suitable for UI to call in the exchange page was released even earlier (in year 2018). There are a lot of things for UI to improve, rather than waiting forever.

Ideally power traders should run (or fund) their own nodes to support the decentralization of the network, but not only rely on free public API nodes. They can do whatever with their own nodes.

BTW public API nodes are free to update their servers parameters to fit users' needs.

@abitmore
Copy link
Member

abitmore commented Jun 4, 2020

Fixed by #2190.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants