Return ref of tween target

[fitzmode]

Hey there. Seems Tween does not return the ref of it's children.

Here's a demo https://codesandbox.io/s/wizardly-mclaren-7oswj?file=/src/App.js

[bitworking]

Hmm, the Tween needs the ref by his own and overwrites it in this case. I could try to first get the ref and set it with the new ref var. But why exactly you need it?

[fitzmode]

I need the ref to call methods on the node. Used div as a a contrived reproducible example.

[bitworking]

Ok let me try later. You also could get the refs with a tweenref.current.getGSAP().targets() call.

Look here: https://bitworking.github.io/react-gsap/src-instructions-low-level-access

[bitworking]

I tried it but cannot set the ref, because it's readonly. I saw your lib (https://github.com/fitzmode/use-dynamic-refs). You perhaps can help me with this?

I do the following, which probably could be optimized, too:

https://github.com/bitworking/react-gsap/blob/master/packages/react-gsap/src/Tween.tsx#L204

React.Children.map(children, child => {
  return React.cloneElement(child, {
    ref: target => {
      this.addTarget(target);
      // this doesn't work and I don't know if
      // setting the target to child.ref is the way to go
      child.ref = target;
    },
  });
})

[fitzmode]

Let me work on it and will come back with a PR

[bitworking]

I found a solution: facebook/react#8873 (comment)

Will be in next version.

[bitworking]

Fixed with version 2.3.0