Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendered bug #132

Closed
msangel opened this issue Mar 29, 2019 · 6 comments
Closed

Rendered bug #132

msangel opened this issue Mar 29, 2019 · 6 comments

Comments

@msangel
Copy link
Collaborator

msangel commented Mar 29, 2019

    static class Foo {
        public String a = "A";
    }

    @Test
    public void renderMapWithPojosExistedThrowError() {
        Map<String, Object> data = new HashMap<String, Object>();
        data.put("foo", new Foo());
        String fooA = Template.parse("{{foo.a}}").render(data);

        assertThat(fooA, is("A"));
    }
@msangel
Copy link
Collaborator Author

msangel commented Mar 30, 2019

My try #4 seems to be latest fix.

@bkiers
Copy link
Owner

bkiers commented Apr 1, 2019

Thanks @msangel for your contributions, much appreciated! I will have a look shortly.

@bkiers
Copy link
Owner

bkiers commented Apr 15, 2019

I had hoped to have a look at your PR's @msangel, but I didn't find the time yet. Kind of a hectic few weeks. Just a quick message that I didn't forget!

@msangel
Copy link
Collaborator Author

msangel commented Apr 23, 2019

Done.

@msangel msangel closed this as completed Apr 23, 2019
@bkiers
Copy link
Owner

bkiers commented Apr 23, 2019

Yes, fixed by fix/132_3

@bkiers
Copy link
Owner

bkiers commented Apr 23, 2019

Again, thanks @msangel. With all the merging, I did break something, I think. See #137. I'll have a closer look in a few days, but if you can easily spot what went wrong, feel free to send a PR 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants