Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trezor-connect version 8 has been deprecated warnings #1652

Closed
1 task done
alyavasilyeva opened this issue Apr 20, 2023 · 4 comments
Closed
1 task done

trezor-connect version 8 has been deprecated warnings #1652

alyavasilyeva opened this issue Apr 20, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@alyavasilyeva
Copy link

Current Behavior

We've switched from bnc-onboard to web3-onboard recently and now we see trezor-connect version 8 has been deprecated. Pease start using @trezor/connect version 9 https://www.npmjs.com/package/@trezor/connect warnings on Sentry.
We were able to reproduce it on localhost too, by trying to connect Trezor wallet.

Expected Behavior

No warnings

Steps To Reproduce

  1. @web3-onboard/core ^2.16.2, @web3-onboard/trezor ^2.3.5,
  2. Mainnet on Goerli network (did not test with others)
  3. Choose Trezor when you connect a wallet
  4. Click Scan Accounts to find addresses
  5. Check console, you should see the warning now

What package is effected by this issue?

@web3-onboard/trezor

Is this a build or a runtime issue?

Runtime

Package Version

^2.16.2

Node Version

16.18.1

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Anything else?

I don't know if it breaks anything since I don't have a Trezor wallet to test, but it is not hard to upgrade it would be awesome 🙂
Screenshot 2023-04-20 at 19 11 56

Sanity Check

  • If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.
@leightkt
Copy link
Contributor

Thanks so much for bringing this to our attention! The team will take a look as soon as possible.

@Adamj1232
Copy link
Member

@alyavasilyeva this has been updated with the latest alpha version of the Trezor package and will be officially released after some testing shortly

@alyavasilyeva
Copy link
Author

@Adamj1232 great, thank you for your quick response!

@Adamj1232
Copy link
Member

@alyavasilyeva this has been updated with v2.3.6 of the Trezor package. Thank you for reporting this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants