Skip to content

Commit

Permalink
test: explicitly set nsec3-iterations to 0
Browse files Browse the repository at this point in the history
knot v3.2 and later does this by default. knot v3.1 still has the default set to
10, but it also introduced a warning that the default will be changed to 0 in
later versions, so it effectively complains about its own default, which then
fails the config check. Let's just set the value explicitly to zero to avoid
that.

~# knotc --version
knotc (Knot DNS), version 3.1.6
~# grep nsec3-iterations test/knot-data/knot.conf || echo nope
nope
~# knotc -c /build/test/knot-data/knot.conf conf-check
warning: config, policy[auto_rollover_nsec3].nsec3-iterations defaults to 10, since version 3.2 the default becomes 0
Configuration is valid

Follow-up to 0652cf8.
  • Loading branch information
mrc0mmand authored and bluca committed Jan 30, 2024
1 parent 4d8f4e0 commit cb3244c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test/knot-data/knot.conf
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ policy:
ds-push: parent_zone_server
ksk-lifetime: 365d
ksk-submission: parent_zone_sbm
nsec3-iterations: 0
nsec3: on
propagation-delay: 1s
signing-threads: 4
Expand Down

0 comments on commit cb3244c

Please sign in to comment.