Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest "internal resolution error" for types wrongly declared from a TS point-of-view (node native esm) #78

Open
dubzzz opened this issue Sep 27, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@dubzzz
Copy link

dubzzz commented Sep 27, 2023

Currently publint is flagging fast-check@3.13.0 as a correctly packaged package.

But if we check onto https://arethetypeswrong.github.io/?p=fast-check%403.13.0 the result is different. The tool reports "Internal resolution error".

I got reported the following issue dubzzz/fast-check#4253 with a simple to use repro. On my side the fix has been to add missing .js extension to all my .d.ts files for esm (I also did it for cjs).

@bluwy
Copy link
Owner

bluwy commented Sep 27, 2023

Hi, yeah this is something not implemented yet as the tool doesn't scan for imports recursively. That can only be done once #13 is started. It's something I want to support though, but at the moment if you want to catch types issue more robustly, arethetypeswrong is your best bet.

@bluwy bluwy added the enhancement New feature or request label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants