Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a selector to filter out pods #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add a selector to filter out pods #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dda3236
added a selector flag
blacksd Feb 6, 2022
be0dbfc
with a handy example too
blacksd Feb 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,16 @@ NAMESPACE NAME NODE REGION ZONE
ns-1 nginx gke-gke-1-p-1-7023cbca-cz4b europe-west1 europe-west1-c
```

You can filter out pods using label selectors with the usual syntax:

```shell
$ kubectl topology pod --all-namespaces --region europe-west1 --selector k8s-app=kube-dns
NAMESPACE NAME NODE REGION ZONE
kube-system kube-dns-5f886bf8d8-s7pcc gke-gke-1-p-1-50120dfc-26gm europe-west1 europe-west1-d
kube-system kube-dns-5f886bf8d8-zhm42 gke-gke-1-p-1-8e1077f6-17st europe-west1 europe-west1-b
kube-system kube-dns-autoscaler-8687c64fc-d5jvm gke-gke-1-p-1-8e1077f6-17st europe-west1 europe-west1-b
```

**NOTE:** `--region` and `--zone` are mutually exclusive.

## License
Expand Down
7 changes: 6 additions & 1 deletion internal/cmd/pod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
func init() {
rootCmd.AddCommand(podCmd)
podCmd.PersistentFlags().BoolP("all-namespaces", "A", false, "List pods across all namespaces.")
podCmd.PersistentFlags().StringP("selector", "l", "", "A label selector to filter out pods.")
}

var podCmd = &cobra.Command{
Expand All @@ -41,11 +42,15 @@ var podCmd = &cobra.Command{
}
r, _ := cmd.Flags().GetString("region")
z, _ := cmd.Flags().GetString("zone")
l, err := cmd.Flags().GetString("selector")
if err != nil {
return err
}
o, err := util.NewTopologyOptions(r, z, n)
if err != nil {
return err
}
p, err := util.ListPods(kubeClient, o)
p, err := util.ListPods(kubeClient, o, l)
if err != nil {
return err
}
Expand Down
3 changes: 2 additions & 1 deletion internal/util/pods.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
"k8s.io/client-go/kubernetes"
)

func ListPods(kubeClient kubernetes.Interface, o *TopologyOptions) (PodList, error) {
func ListPods(kubeClient kubernetes.Interface, o *TopologyOptions, s string) (PodList, error) {
n, err := ListNodes(kubeClient, o)
if err != nil {
return nil, err
Expand All @@ -28,6 +28,7 @@ func ListPods(kubeClient kubernetes.Interface, o *TopologyOptions) (PodList, err
for _, nn := range n {
p, err := kubeClient.CoreV1().Pods(o.Namespace).List(metav1.ListOptions{
FieldSelector: "spec.nodeName=" + nn.Name,
LabelSelector: s,
})
if err != nil {
return nil, err
Expand Down