From a896f14ea947279847cd5ec1dcf83850d251a001 Mon Sep 17 00:00:00 2001
From: Richard Lau <rlau@redhat.com>
Date: Sat, 15 Jun 2024 18:23:35 +0100
Subject: [PATCH] src: remove `base64` from `process.versions`

The `base64` dependency was previously removed along with the update
script (`tools/dep_updaters/update-base64.sh`) but the generated header,
`src/base64_version.h` was left behind and `process.versions` was still
listing the last version of `base64` that was included in Node.js before
it was removed

Refs: https://github.com/nodejs/node/pull/52714
PR-URL: https://github.com/nodejs/node/pull/53442
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
---
 src/base64_version.h                   | 6 ------
 src/node_metadata.cc                   | 2 --
 src/node_metadata.h                    | 3 +--
 test/parallel/test-process-versions.js | 1 -
 4 files changed, 1 insertion(+), 11 deletions(-)
 delete mode 100644 src/base64_version.h

diff --git a/src/base64_version.h b/src/base64_version.h
deleted file mode 100644
index ce3d7c03f8c979..00000000000000
--- a/src/base64_version.h
+++ /dev/null
@@ -1,6 +0,0 @@
-// This is an auto generated file, please do not edit.
-// Refer to tools/dep_updaters/update-base64.sh
-#ifndef SRC_BASE64_VERSION_H_
-#define SRC_BASE64_VERSION_H_
-#define BASE64_VERSION "0.5.2"
-#endif  // SRC_BASE64_VERSION_H_
diff --git a/src/node_metadata.cc b/src/node_metadata.cc
index 20206039445d54..cc4f732cd11696 100644
--- a/src/node_metadata.cc
+++ b/src/node_metadata.cc
@@ -2,7 +2,6 @@
 #include "acorn_version.h"
 #include "ada.h"
 #include "ares.h"
-#include "base64_version.h"
 #include "brotli/encode.h"
 #include "cjs_module_lexer_version.h"
 #include "llhttp.h"
@@ -113,7 +112,6 @@ Metadata::Versions::Versions() {
 
   acorn = ACORN_VERSION;
   cjs_module_lexer = CJS_MODULE_LEXER_VERSION;
-  base64 = BASE64_VERSION;
   uvwasi = UVWASI_VERSION_STRING;
 
 #if HAVE_OPENSSL
diff --git a/src/node_metadata.h b/src/node_metadata.h
index 4a4a36befb8d82..5400220424e8d7 100644
--- a/src/node_metadata.h
+++ b/src/node_metadata.h
@@ -51,8 +51,7 @@ namespace node {
   V(sqlite)                                                                    \
   V(ada)                                                                       \
   NODE_VERSIONS_KEY_UNDICI(V)                                                  \
-  V(cjs_module_lexer)                                                          \
-  V(base64)
+  V(cjs_module_lexer)
 
 #if HAVE_OPENSSL
 #define NODE_VERSIONS_KEY_CRYPTO(V) V(openssl)
diff --git a/test/parallel/test-process-versions.js b/test/parallel/test-process-versions.js
index febeaf36492b42..374c339cd814f5 100644
--- a/test/parallel/test-process-versions.js
+++ b/test/parallel/test-process-versions.js
@@ -23,7 +23,6 @@ const expected_keys = [
   'sqlite',
   'ada',
   'cjs_module_lexer',
-  'base64',
 ];
 
 const hasUndici = process.config.variables.node_builtin_shareable_builtins.includes('deps/undici/undici.js');