Sniff to limit the use of new?

[bmitch]

Instead of using new should be using DI. Should this be sniffed out?

[bmitch]

Maybe leave this as a warning and suggest using DI instead if applicable.

[kevin-schmitt]

Hello,

This issue is always ok? if yes i take please.

Thanks

[kevin-schmitt]

Hello,

Can you help me please ?
I try to register new sniff without success i have message 'sniff no registered'
In my test

<?php declare(strict_types = 1);

namespace Codor\Tests\Sniffs\Classes;

use Codor\Tests\BaseTestCase;

/** @group Classes */
class NewInstanceSniffTest extends BaseTestCase
{

    public function setup()
    {
        parent::setup();

        $this->runner->setSniff('Codor.Classes.NewInstance')->setFolder(__DIR__.'/Assets/NewInstanceSniff/');
    }

    /** @test */
    public function a_constructor_have_warning_if_use_new_class_in_constructor()
    {
        $results = $this->runner->sniff('NewInConstructor.inc');
        $this->assertSame(0, $results->getErrorCount());
        $this->assertSame(1, $results->getWarningCount());

    }
}

I created the sniff

When i run the test

Thanks

[villfa]

I see there is a typo in the class name of the Sniff: Intsance instead of Instance.
Not sure if it will fix your issue though.

[kevin-schmitt]

Hello :)

You can close this issue please ?

[villfa]

Closing since it's done in #153.
Thanks @kevin-schmitt