Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this best practice? #183

Closed
kolomiec opened this issue Nov 10, 2023 · 2 comments
Closed

Does this best practice? #183

kolomiec opened this issue Nov 10, 2023 · 2 comments

Comments

@kolomiec
Copy link

private String EXPECTED_MESSAGE = "The key to efficient learning is practice!";

For me this var make coupling between tests, what do you think about it?

@kolomiec
Copy link
Author

Also, just wondering, regarding this test class, why do you need to crazy logic in the com.bobocode.intro.ExerciseIntroductionTest#encodeMessageReturnsCorrectPhrase? Vs just
assertEquals(exerciseIntroduction.encodeMessage(EXPECTED_MESSAGE), "VGhlIGtleSB0byBlZmZpY2llbnQgbGVhcm5pbmcgaXMgcHJhY3RpY2Uh");

@kolomiec
Copy link
Author

Moved to #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant