From 3fef6969863b9a68ba851f6b70848f6e473afee5 Mon Sep 17 00:00:00 2001 From: jjinwoong Date: Wed, 16 Nov 2022 14:28:37 +0900 Subject: [PATCH 1/2] =?UTF-8?q?[refactor]=20TabCoordinator=EB=82=B4?= =?UTF-8?q?=EC=9D=98=20TabBarPage=EC=9D=98=20=EB=A9=94=EC=84=9C=EB=93=9C?= =?UTF-8?q?=EB=A5=BC=20=EA=B3=84=EC=82=B0=20=ED=94=84=EB=A1=9C=ED=8D=BC?= =?UTF-8?q?=ED=8B=B0=EB=A1=9C=20=EB=B3=80=EA=B2=BD?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../DailyQuest/Application/Protocols/TabCoordinator.swift | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/DailyQuest/DailyQuest/Application/Protocols/TabCoordinator.swift b/DailyQuest/DailyQuest/Application/Protocols/TabCoordinator.swift index c55ff56..cf03ed8 100644 --- a/DailyQuest/DailyQuest/Application/Protocols/TabCoordinator.swift +++ b/DailyQuest/DailyQuest/Application/Protocols/TabCoordinator.swift @@ -29,7 +29,7 @@ enum TabBarPage { } } - func pageTitleValue() -> String { + var pageTitleValue: String { switch self { case .home: return "홈" @@ -40,7 +40,7 @@ enum TabBarPage { } } - func pageOrderNumber() -> Int { + var pageOrderNumber: Int { switch self { case .home: return 0 @@ -51,7 +51,7 @@ enum TabBarPage { } } - func pageIcon() -> UIImage? { + var pageIcon: UIImage? { switch self { case .home: return UIImage(systemName: "house") From 8a5275d89d85bab86410c156ca97edb010568bb6 Mon Sep 17 00:00:00 2001 From: jjinwoong Date: Wed, 16 Nov 2022 14:29:15 +0900 Subject: [PATCH 2/2] =?UTF-8?q?[refactor]=20AppCoordinator=EC=97=90?= =?UTF-8?q?=EC=84=9C=20=EB=B3=80=EA=B2=BD=EC=82=AC=ED=95=AD=EC=97=90=20?= =?UTF-8?q?=EB=94=B0=EB=9D=BC=EC=84=9C,=20=EB=A9=94=EC=84=9C=EB=93=9C->?= =?UTF-8?q?=EA=B3=84=EC=82=B0=ED=94=84=EB=A1=9C=ED=8D=BC=ED=8B=B0=20?= =?UTF-8?q?=EC=82=AC=EC=9A=A9=EC=9C=BC=EB=A1=9C=20=EB=B3=80=EA=B2=BD?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- DailyQuest/DailyQuest/Application/AppCoordinator.swift | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/DailyQuest/DailyQuest/Application/AppCoordinator.swift b/DailyQuest/DailyQuest/Application/AppCoordinator.swift index 9c3924a..ca36941 100644 --- a/DailyQuest/DailyQuest/Application/AppCoordinator.swift +++ b/DailyQuest/DailyQuest/Application/AppCoordinator.swift @@ -29,7 +29,7 @@ final class AppCoordinator: NSObject, TabCoordinator, UITabBarControllerDelegate private func prepareTabBarController(withTabControllers tabControllers: [UIViewController]) { tabBarController.delegate = self tabBarController.setViewControllers(tabControllers, animated: true) - tabBarController.selectedIndex = TabBarPage.home.pageOrderNumber() + tabBarController.selectedIndex = TabBarPage.home.pageOrderNumber tabBarController.tabBar.isTranslucent = false } @@ -38,9 +38,9 @@ final class AppCoordinator: NSObject, TabCoordinator, UITabBarControllerDelegate let navController = UINavigationController() navController.setNavigationBarHidden(false, animated: false) - navController.tabBarItem = UITabBarItem.init(title: page.pageTitleValue(), - image: page.pageIcon(), - tag: page.pageOrderNumber()) + navController.tabBarItem = UITabBarItem.init(title: page.pageTitleValue, + image: page.pageIcon, + tag: page.pageOrderNumber) switch page { case .home: