Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change context.TODO() with better context handling #71

Closed
srgothi92 opened this issue Aug 5, 2021 · 1 comment
Closed

Change context.TODO() with better context handling #71

srgothi92 opened this issue Aug 5, 2021 · 1 comment

Comments

@srgothi92
Copy link
Contributor

srgothi92 commented Aug 5, 2021

Image I'm using:
N/A

Issue or Feature Request:
Issue

Description

Kubernetes go client library was updated as part of PR-70, but the newer version requires context in lots of API's. The context was difficult to determine so It was set as context.TODO() as part of PR-70. We should change it to more meaningful context.

@cbgbt
Copy link
Contributor

cbgbt commented Feb 15, 2022

This shouldn't be an issue in the latest Update Operator release, 0.2.0, which has changed implementations to use kube-rs

@cbgbt cbgbt closed this as completed Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants