Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Menu sometimes cut off to three items #170

Open
janvanveldhuizen opened this issue Apr 30, 2024 · 5 comments
Open

Main Menu sometimes cut off to three items #170

janvanveldhuizen opened this issue Apr 30, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@janvanveldhuizen
Copy link
Contributor

janvanveldhuizen commented Apr 30, 2024

I built the first draft of my own website: https://janvv.nl/. This is an attempt to migrate my website from papasmurf.nl to the Perplex theme.

There is still a lot of fine-tuning to be done, but I have noticed that the menu items disappear when you reduce the screen width. However, they reappear when you make the screen even smaller.

Is there something that I can do to prevent this behavior?

image

image

image

image

@bowman2001 bowman2001 self-assigned this May 5, 2024
@bowman2001 bowman2001 added the enhancement New feature or request label May 5, 2024
@bowman2001
Copy link
Owner

Hi Jan,

Thanks for your report!

No, there is currently nothing you can do to change the layout of the menu. There is simply not enough space to show all your entries in the 3-column layout version because there is only one column of space reserved for this menu. (One column is around the half of the main text width)

Your menu entries need around 1 and a half major column and this could be working, if I offer another layout option for larger site menus for this layout size. There is still enough empty space to use, if you don't add more entries.

In the near future I'm not going to find the time to implement this alternative layout for site menus, because I've just started a completely new and demanding full-time job. But this would be a useful enhancement and its on the top of my list.

@janvanveldhuizen
Copy link
Contributor Author

Thank you for your reply.
You might see pull requests coming in from my side.
I'll happily spend some time enhancing the best Hugo theme I've seen so far.

@bowman2001
Copy link
Owner

bowman2001 commented May 6, 2024

When you want to improve the layout, please do not alter the main style file. You can add customized CSS, the process is documented.

Should you have a solution for the small menu space in the 3-column layout version, I would sure take a look at your CSS and start to implement an alternative layout option.

If you would like to add functionality, please raise an issue with a feature request, so I know what you are working on.

@janvanveldhuizen
Copy link
Contributor Author

janvanveldhuizen commented May 19, 2024

I have never done this before. I investigated and studied how the grid mechanism works in CSS. After experimenting with it for a day, I succeeded in displaying my entire menu at various screen sizes. See: janvv.nl.
The custom CSS feature is awesome.
My CSS can be found here; https://gitlab.com/janware/papasmurf.website/-/blob/main/assets/css/custom/menu.css.
As for me, this issue can be closed, but maybe you'll want to keep it for later improvement.

@bowman2001
Copy link
Owner

Thanks, your solution is an improvement!

As soon as I can find the time, I would like to work on the primary menu and will look into your CSS as an inspiration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants