[CLOSED] New shell API to get the hash

[core-ai-bot]

Issue by nethip
Monday Jun 05, 2017 at 08:23 GMT
Originally opened as adobe#603

---

This PR is heavily inspired by https://oroboro.com/unique-machine-fingerprint/ in trying to create a hash out of a system based on various parameters like network interfaces, volume, CPU e.t.c.

Relevant PR on Brackets side: adobe/brackets#13419

---

nethip included the following code: https://github.com/adobe/brackets-shell/pull/603/commits

[core-ai-bot]

Comment by nethip
Monday Jun 05, 2017 at 08:26 GMT

---

abhijit apte, @saurabh95 Please review this.

[core-ai-bot]

Comment by nethip
Tuesday Jun 13, 2017 at 04:11 GMT

---

@abhijitapte I will address the review comments. Thanks for reviewing this PR. Appreciate it!

[core-ai-bot]

Comment by nethip
Thursday Jun 15, 2017 at 04:35 GMT

---

@abhijitapte I have addressed the review comments. Can you have a look again and tell me if this is OK now?

Note: I will be handling the linux change in a different PR.

[core-ai-bot]

Comment by nethip
Thursday Jun 15, 2017 at 08:03 GMT

---

Raised PR for Linux side @ adobe#607

[core-ai-bot]

Comment by abhijitapte
Thursday Jun 15, 2017 at 11:25 GMT

---

LGTM

[core-ai-bot]

Comment by nethip
Thursday Jun 15, 2017 at 11:29 GMT

---

Thanks for reviewing this PR @abhijitapte

[core-ai-bot]

Comment by MarcelGerber
Friday Jun 16, 2017 at 09:19 GMT

---

For me on Windows, I cannot build brackets-shell due to snprintf: identifier not found.
Which VS version are you building with? I'm using VS 2012 Express.

[core-ai-bot]

Comment by nethip
Friday Jun 16, 2017 at 13:32 GMT

---

@marcelgerber I am using VS 2015. It seems to be building fine on my system. I will try to build this again in the office on Monday. But thanks for building and letting me know. And good to hear from you after a long time 😁