-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] ESLint: enabled no-trailing-spaces and eol-last rules #10340
Comments
Comment by zaggino LGTM from me |
Comment by petetnt 👍 from me too |
Comment by ficristo
|
Comment by abose
|
Comment by ficristo
|
Comment by ficristo
I'm not sure to have understood: do you mean changing the config to this: |
Comment by ficristo When I written the PR to integrate ESLint I tried to use similar rules to the ones already there. |
Comment by abose What should we do in this case then? |
Comment by zaggino I've merged |
Comment by peterflynn
I would strongly suggest we change the ESLint setting to If I'd noticed this sooner I would have also suggested reverting all the changes that remove whitespace on blank lines, so that we don't have verbose diffs where people editing the code gradually start reintroducing all that indent whitespace... but I guess it's too late for that now :-/ |
Issue by ficristo
Saturday Dec 12, 2015 at 10:36 GMT
Originally opened as adobe/brackets#11998
I wanted to enable the
indent
rule but it seemed to be influenced by the trailing whitespaces.So I've enabled
no-trailing-spaces
rule and, since there were only a few warnings theeol-last
rule too.Sorry for the big PR but it's only whitespaces changes and so there should not be any change in behaviour.
@
abose@
zaggino This PR can bitrot easily: I appreciate a fast turnaround.ficristo included the following code: https://github.com/adobe/brackets/pull/11998/commits
The text was updated successfully, but these errors were encountered: