[CLOSED] Fixed htmlmixed highlighting.

[core-ai-bot]

Issue by ficristo
Saturday May 14, 2016 at 11:17 GMT
Originally opened as adobe/brackets#12422

---

Add text/babel and text/jsx to the jsx mode.
My angular template (ng-template) weren't syntax hightlighted so I changed the mode.
I'm not sure is totally correct but seems to work ok.
This should fix adobe/brackets#12208 too.

/cc@MarcelGerber@petetnt

---

ficristo included the following code: https://github.com/adobe/brackets/pull/12422/commits

[core-ai-bot]

Comment by petetnt
Saturday May 14, 2016 at 12:32 GMT

---

Tested and the syntax highlighting LGTM.

Indentation is broken though (resets to 0 on every line) on the JSX mode, I think it might be an CodeMirror issue...

Should text/babel and text/jsx be added to

https://github.com/adobe/brackets/blob/656a0ee1d9889e853a77a4d9b12b9a82e6f86c55/src/extensions/default/HTMLCodeHints/HtmlAttributes.json#L214

and

https://github.com/adobe/brackets/blob/656a0ee1d9889e853a77a4d9b12b9a82e6f86c55/src/extensions/default/SVGCodeHints/SVGAttributes.json#L69

too so that they show up on <script type="..."> code hints too?

[core-ai-bot]

Comment by ficristo
Saturday May 14, 2016 at 17:23 GMT

---

I've added them.

[core-ai-bot]

Comment by ficristo
Sunday May 15, 2016 at 13:10 GMT

---

@MiguelCastillo Thank you.

[core-ai-bot]

Comment by MiguelCastillo
Sunday May 15, 2016 at 13:14 GMT

---

You bet! Thank you for your PR.