Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Errors are not highlighted in the default dark theme #11091

Open
3 tasks done
core-ai-bot opened this issue Aug 30, 2021 · 5 comments
Open
3 tasks done

[CLOSED] Errors are not highlighted in the default dark theme #11091

core-ai-bot opened this issue Aug 30, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by ficristo
Sunday Jan 22, 2017 at 12:09 GMT
Originally opened as adobe/brackets#13057

Prerequisites

  • Can you reproduce the problem with Debug -> Reload Without Extensions?
  • Did you perform a cursory search to see if your bug or enhancement is already reported?
  • Did you read the Troubleshooting guide?

For more information on how to write a good bug report read here
For more information on how to contribute read here

Description

In the default dark theme, errors are not highlighted.
theme-error

CodeMirror add the class cm-error correctly and in src/extensions/default/DarkTheme/main.less there is a class for cm-error which should highlight the tag in red.

Steps to Reproduce

  1. Switch to the default dark theme
  2. Paste this snippet
<html>
    <div>
</html>

Versions

Windows 10
master
@core-ai-bot
Copy link
Member Author

Comment by ficristo
Sunday Jan 22, 2017 at 12:10 GMT

Since I believe (I don't have investigated) it is a problem of overriding correctly the styles, marking as starter issue.
/cc@swmitra@MiguelCastillo

@core-ai-bot
Copy link
Member Author

Comment by swmitra
Sunday Jan 22, 2017 at 13:26 GMT

@ficristo you are absolutely right. The problem is the position and grouping of cm-error. Ideally cm-error should be defined after defining all the CM token selectors in the theme less file. We will fix this in 1.9.

@core-ai-bot
Copy link
Member Author

Comment by petetnt
Monday Jan 23, 2017 at 11:19 GMT

Weird, I fixed this in the light theme a long while back: adobe/brackets#11894 🤔

@core-ai-bot
Copy link
Member Author

Comment by swmitra
Tuesday Jan 24, 2017 at 03:11 GMT

@petetnt yes, that's exactly the fix what we need in dark theme as well.

@core-ai-bot
Copy link
Member Author

Comment by petetnt
Sunday Jan 29, 2017 at 21:58 GMT

Fixed in #13068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot