-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] Sidebar resize refactorization (2) #1857
Comments
Comment by redmunds In master, the area that shows the resize cursor is to the right of the panel edge, but in your branch it's too the left of the panel edge. Logically, I think it makes more sense to have the resize area over the panel that's being resized, but it causes a problem in this case because it's over the vertical scrollbar. It makes it difficult to grab the scrollbar with the mouse -- there's only 1-2 pixels where you can grab it. |
Comment by redmunds Initial code review is complete. This cleans up a lot of code! Just a couple things to fix. |
Comment by jbalsas
|
Comment by redmunds After reading the comments in adobe/brackets#1854, I am not sure if it's fixed yet. Give it a try in a new branch, but I don't want these changes to wait on that. Looks good. Merging. |
Comment by jbalsas You're right... I guess I'll leave it to rest for a while then ;) Thanks! |
Issue by jbalsas
Sunday Oct 21, 2012 at 17:24 GMT
Originally opened as adobe/brackets#1908
This is the final step (hopefully) on the sidebar resize refactorization proposed initially in adobe/brackets#1811 and developed in several steps in adobe/brackets#1820, adobe/brackets#1838 and adobe/brackets#1899
It moves almost all the resize functionality for the sidebar into the
utils/Resizer
module.Due to the last changes on flexbox, it also adds a new
data-forcemargin
to control the margins that need to be pushed while resizing an element.@
redmunds With a bit of luck this could be the end of the Resizer chapter for now ;)jbalsas included the following code: https://github.com/adobe/brackets/pull/1908/commits
The text was updated successfully, but these errors were encountered: