Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Extension Manager font is hard to read on Windows #4215

Open
core-ai-bot opened this issue Aug 29, 2021 · 14 comments
Open

[CLOSED] Extension Manager font is hard to read on Windows #4215

core-ai-bot opened this issue Aug 29, 2021 · 14 comments

Comments

@core-ai-bot
Copy link
Member

Issue by peterflynn
Wednesday Jul 24, 2013 at 00:44 GMT
Originally opened as adobe/brackets#4554


The small, extra-lightweight font used for extension descriptions is very spindly on Windows, making the text hard to read and less attractive.

This seems to have regressed from before. Today:
em-sprint28
Sprint 26:
em-sprint26

I'm guessing this is the same Chromium/CEF font rendering change that caused #4391...

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Jul 24, 2013 at 00:45 GMT


Tagging Sprint 28 since we should at least consider whether we need to do anything here before shipping.

We might also want to scrub the UI for other uses of light+small Source Sans that would experience similar issues.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Jul 24, 2013 at 01:01 GMT


I can confirm that small text in other places like the About dialog is also affected. (Also in the About dialog, you can see a change in image antialiasing -- all the gravatars are shifted about 1px within their frames).

But I don't see hue changes anywhere other than the text, so this appear to not involve color profiles directly. It may be that something about compositing or antialiasing changed at the same time (or in support of the color correction) that is causing this.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Jul 24, 2013 at 01:12 GMT


The CEF change definitely only affects text rendering in mainstream cases -- I've verified on a number of websites now. Text is noticeably thinner (especially small text) and colored text is noticeably desaturated, but images and background fills are completely unchanged.

@core-ai-bot
Copy link
Member Author

Comment by pthiess
Wednesday Jul 24, 2013 at 18:14 GMT


@JeffryBooher Please take a look if there was anything we could do in the short term (this sprint).@dangoor is out today, please chat with@peterflynn or@njx if you felt we should defer.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Jul 24, 2013 at 20:10 GMT


@larz0 We'd like your thoughts on this. I'm proposing we do a workaround by bumping from font weight from light (200) up to normal on Windows. That's heavier than it looked before, but much more readable:

With workaround:
em-workaround
Without workaround:
em-sprint28
Sprint 26:
em-sprint26

IMHO since this is primary content it's ok for the text to be less grayed out...

@core-ai-bot
Copy link
Member Author

Comment by larz0
Wednesday Jul 24, 2013 at 20:19 GMT


I agree@peterflynn. Thanks for the heads up!

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Jul 24, 2013 at 22:28 GMT


Did some further research. Looks like this is caused by Chromium bug 146407, which has the same symptoms: fainter text and desaturated text colors only/especially on Windows. It broke in Chrome 22, which matches what we're seeing: in Sprint 27 we upgraded CEF from 1180 to 1453, which corresponds to upgrading from Chrome 21 to Chrome 27 -- and that's indeed when we first saw the problem. (Considering that was jumping forward 10 months in Chrome's history, I'm almost surprised that font rendering and a couple V8 crashes are the only unexpected changes we've seen!)

@core-ai-bot
Copy link
Member Author

Comment by larz0
Wednesday Jul 24, 2013 at 22:33 GMT


Damn… hope that's a high priority bug for the Chromium Team.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Jul 24, 2013 at 22:41 GMT


There's a comment in that bug by a Chrome dev saying the cause is that Chrome has started assuming all displays are calibrated to sRGB because "most displays today" are (which in my experience isn't true). It also seems that no other browser (including Safari) makes that assumption, judging by all the comparison screenshots there showing Chrome differing from the rest of the pack. But the developer comment almost suggests they consider it NAB. Would be interesting to get thoughts from some in-house font experts here (e.g. TypeKit) on what sorts of colorspace/gamma assumptions are safe...

The bug comment thread near the end gets a little jumbled up with a different issue (137692) where certain poorly-hinted webfonts render with no AA at all on Windows. That's blocked awaiting DirectWrite support and was never working; whereas the "spindly" AA that's the issue here is effectively a "regression" from Chrome 22 onwards. There's plenty of momentum on the DirectWrite stuff but unfortunately little or none on the "spindly" issue we're hitting -- although it's possible using DirectWrite for all text would remove the sRGB assumption and go back to whatever the OS assumes natively (which seems more correct given that text looks better in IE).

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Jul 24, 2013 at 22:46 GMT


One interesting thing to note about this is that the effect depends on text brightness -- all text gets paler, so light colored text actually got fatter while dark colored text got more spindly. You can see an example of light text "fattening" if you compare the working set list between sprints.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Jul 25, 2013 at 00:00 GMT


@larz0 I noticed one other place that might be affected by this: dialog box messages.

For example:
savedialog_s28
aboutdialog_s28

The font size is a little bigger in dialogs, so it's not nearly as bad... but it's still noticeably thin. Do you think those are hard-to-read enough to warrant correcting too?

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Jul 25, 2013 at 01:05 GMT


Closing. We'll file a separate bug for the other dialogs and punt that to next sprint.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Thursday Jul 25, 2013 at 01:30 GMT


@peterflynn FYI #4567

@core-ai-bot
Copy link
Member Author

Comment by GarthDB
Thursday Jul 25, 2013 at 14:24 GMT


We're looking at the same issue with Topcoat's website. Looks better on firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant