[CLOSED] Syntax for line:col jumps in QuickOpen search queries

[core-ai-bot]

Issue by jbalsas
Monday Oct 21, 2013 at 21:39 GMT
Originally opened as adobe/brackets#5612

---

Hey,@TomMalbran, this overtakes #3238. I finally got around this long forgotten pull request. I've cherry-picked the old commits on top of master and added some tests. I may be a little bit rusty, so please, check if everything's in there or if I missed something.

@peterflynn@dangoor I've seen that the test gave some issues in the past, so you may want to check it out

---

jbalsas included the following code: https://github.com/adobe/brackets/pull/5612/commits

[core-ai-bot]

Comment by TomMalbran
Tuesday Nov 05, 2013 at 18:24 GMT

---

And now, I am the one with no time. And I don't even remember much about the original PR. If someone else has time to check this PR, that would be great. If not I could try and check it in a few weeks. Sorry for the delay.

[core-ai-bot]

Comment by jbalsas
Wednesday Nov 13, 2013 at 14:29 GMT

---

@TomMalbran No problem, I don't think there's anyone rooting or waiting for this anyway ;)

Actually, I was thinking that maybe we'd like to just leave it out and consolidate this card in the broader Quick Open Trello story.@peterflynn What do you think?

[core-ai-bot]

Comment by TomMalbran
Wednesday Nov 13, 2013 at 19:59 GMT

---

I did just a review of the code. I have to go now. I will try to later test it and check the tests.

[core-ai-bot]

Comment by TomMalbran
Thursday Dec 19, 2013 at 01:52 GMT

---

@jbalsas Sorry for the late reply. The tests look good and so does the code besides the comments I made before. But I wasn't able to test since Brackets fails to open. Could you merge with master? I can then do a final test and we can finally merge this :)

[core-ai-bot]

Comment by TomMalbran
Sunday Jan 19, 2014 at 03:05 GMT

---

@jbalsas I just merged and tested it and it works great. Besides some minor nits, my only concern is if we should show an error when the user selects a column greater than the maximum columns in the line, since there is no visual indication in the editor as to what is happening. If you are busy I could fix the nits and merge it.

CC@larz0 to consider if we should show an error when the given column is greater than the columns in the line.

[core-ai-bot]

Comment by larz0
Sunday Jan 19, 2014 at 03:21 GMT

---

@TomMalbran I like the current behavior, i.e. cursor stays on the last column. It's obvious that it can't go beyond that and people that use this feature will know this.

[core-ai-bot]

Comment by TomMalbran
Sunday Jan 19, 2014 at 03:24 GMT

---

Cool. I guess I could then fix the small nits and merge it :)

[core-ai-bot]

Comment by larz0
Sunday Jan 19, 2014 at 03:27 GMT

---

Schweet~

[core-ai-bot]

Comment by TomMalbran
Sunday Jan 19, 2014 at 06:47 GMT

---

Fixed the nits and finally merging this. Woot :)