[CLOSED] Close CSS Code Hints after inputting property value

[core-ai-bot]

Issue by MarcelGerber
Wednesday Feb 04, 2015 at 20:10 GMT
Originally opened as adobe/brackets#10524

---

For #9496 and #4888

---

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/10524/commits

[core-ai-bot]

Comment by nethip
Friday Feb 06, 2015 at 12:55 GMT

---

@MarcelGerber I took this change and it does not seem to solve #9496. I am not sure if this makes the issue better though.

[core-ai-bot]

Comment by MarcelGerber
Friday Feb 06, 2015 at 13:09 GMT

---

Hm, it definitely works for me. So, just to be sure, these are the steps I followed:

1. Type position: absolute;
2. Place your mouse before the p
3. Type (without using Code Hints!) left: auto; - without a trailing space
4. Press Enter

Before: left: auto;align-content: : absolute;
After: left: auto;[Newline]position: absolute;

[core-ai-bot]

Comment by kylelondonuk
Monday Apr 27, 2015 at 10:43 GMT

---

Hi, I opened issue #9496 and was wondering whether this fix is available yet? the problem still seems to exist in Brackets 1.3 downloaded today.

Cheers

[core-ai-bot]

Comment by nethip
Monday Apr 27, 2015 at 12:08 GMT

---

@kylelondonuk This is not merged yet.

[core-ai-bot]

Comment by ficristo
Saturday Jan 30, 2016 at 10:13 GMT

---

FWIW I can confirm the STR above and this PR fixes it.

[core-ai-bot]

Comment by MarcelGerber
Saturday Apr 30, 2016 at 18:40 GMT

---

I do think this fix should be reviewed soon. Would you mind? Maybe@abose?

[core-ai-bot]

Comment by ficristo
Wednesday Jul 20, 2016 at 19:02 GMT

---

There is a test failing under Extensions \ CSS Code Hinting. Could you take a look?

By the way I'd write the code like the following: I find it easier to read.

-            lastContext = CSSUtils.PROP_NAME;
+            if (lastContext === CSSUtils.PROP_VALUE) {
+                // Close the session if we're coming from a property value.
+                // See https://github.com/adobe/brackets/issues/9496
+                return null;
+            }
+
+            lastContext = CSSUtils.PROP_NAME;
             needle = needle.substr(0, this.info.offset);

[core-ai-bot]

Comment by MarcelGerber
Friday Jul 22, 2016 at 21:23 GMT

---

@ficristo With latest master merged in, all tests pass for me.
I've also incorporated your suggested code style change.

[core-ai-bot]

Comment by ficristo
Saturday Jul 23, 2016 at 07:43 GMT

---

You are missing a brace.

[core-ai-bot]

Comment by MarcelGerber
Saturday Jul 23, 2016 at 09:37 GMT

---

Argh, yesterday simply wasn't my day. Fixed it now and squashed the commits as.
Should be good to go after one last look.

[core-ai-bot]

Comment by ficristo
Saturday Jul 23, 2016 at 10:30 GMT

---

Thank you, LGTM.