Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hls_time: Invalid chars on ffmpeg version 3 #347

Open
Euklios opened this issue Aug 21, 2024 · 1 comment
Open

hls_time: Invalid chars on ffmpeg version 3 #347

Euklios opened this issue Aug 21, 2024 · 1 comment
Labels

Comments

@Euklios
Copy link
Collaborator

Euklios commented Aug 21, 2024

Describe the bug
HlsOutputBuilder is incompatible with the hls format used in ffmpeg version 3.
FFmpeg switched from second based value (eg. 120) to the format we use (2:00, hh:mm:ss) in version 4.
Therefore, the hls output is partially incompatible with version 3 (and probably lower)

To Reproduce
Running FFmpegHlsOutputBuilderTest while using ffmpeg version 3.

Expected behavior
To avoid this, we should probably use the second based representation instead.
Alternatively, I could stop testing on ffmpeg version 3.

Version (if applicable):

  • OS: any
  • Java Version 8+
  • FFmpeg version 3 (Not affecting 4 and higher)

Additional context

Console:

ffmpeg -y -v error -i src/test/resources/net/bramp/ffmpeg/samples/big_buck_bunny_720p_1mb.mp4 -f hls -b:v 1000 -hls_time 00:00:05 -hls_segment_filename tmp/file%03d.ts -hls_init_time 00:00:00.003 -hls_list_size 3 -hls_base_url test1234/ tmp/output.m3u8
[hls muxer @ 0x5315b00] [Eval @ 0x7ffe7282f2d0] Invalid chars ':00:05' at the end of expression '00:00:05'
[hls muxer @ 0x5315b00] Unable to parse option value "00:00:05"
[hls muxer @ 0x5315b00] Error setting option hls_time to value 00:00:05.
@Euklios Euklios added the bug label Aug 21, 2024
Euklios added a commit to Euklios/ffmpeg-cli-wrapper that referenced this issue Aug 21, 2024
@Euklios Euklios reopened this Aug 21, 2024
@Euklios
Copy link
Collaborator Author

Euklios commented Aug 21, 2024

Reverted the commit due to unexpected compatibility issues.
I can't provide a more sophisticated fix until async is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant