This repository has been archived by the owner on Mar 6, 2019. It is now read-only.
Confirmations #106
Merged
Confirmations #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README - include synopsis of stand-alone build instructions
event_type_load.h - include tab classification in structure
ads_impl.{h,cc} -
- move load event to classifier method to get accurate log entries
- add GetRegion method for use with brave-core/ui
- more logging in classifier method
- make adsPerDay a no-op until design/product decides what to do with that feature
- more logging for onTimer to see why it fires
bundle.cc - fix hierarchy typo
mock_ads_client.cc - s/result/status to avoid double definition issue
note that client_->GetLastPageClassification is no longer needed
This was referenced Jan 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.